Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ARNs and IDs instead of lookups #11

Open
lorenzoaiello opened this issue Nov 26, 2019 · 2 comments
Open

Enable ARNs and IDs instead of lookups #11

lorenzoaiello opened this issue Nov 26, 2019 · 2 comments

Comments

@lorenzoaiello
Copy link
Contributor

It would be great if ARNs and IDs (eg. subnet IDs) could be provided instead of relying on the module to do data lookups (which may require changes to other infrastructure other than Kong).

@DennoVonDiesel
Copy link
Contributor

Curious the advantage of this approach. Relying on meta data/tags isn't intrusive setup changes ands offers flexibility when redeploying to a new VPC with different values.

@lorenzoaiello
Copy link
Contributor Author

For us, the advantage is not necessarily being tied to metadata/tags, but rather giving us the option on how/where to get the list from. If we want to pull from metadata for a particular deployment then we can do that lookup and pass in the IDs.

In most deployments, we create the VPC in the same stack that deploys Kong and its easier to take the output of the AWS VPC Module and just pass it right into this module than to ensure that all of the metadata lines up nicely.

I haven't checked the other providers, but most of the AWS Modules take lists of IDs as inputs (eg. https://github.com/terraform-aws-modules/terraform-aws-eks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants