From 8c744444b4d0ed40ec75a9da633d8e99afa0b59e Mon Sep 17 00:00:00 2001 From: Adam DeHaven Date: Fri, 17 Dec 2021 15:38:17 -0500 Subject: [PATCH 1/5] chore(node): use node 14 Use node 14 instead of node 12. --- .github/workflows/publish.yml | 4 ++-- .github/workflows/test.yml | 2 +- package.json | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index c4e36e9862..7b5c049431 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [12.x] + node: [14.x] steps: - uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node }} @@ -44,7 +44,7 @@ jobs: token: ${{ secrets.KONGPONENTS_BOT_PAT }} - uses: actions/setup-node@v1 with: - node-version: 12.x + node-version: 14.x - name: setup git run: | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c6345f7664..a4e0dafee1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -12,7 +12,7 @@ jobs: strategy: fail-fast: false matrix: - node: [12.x] + node: [14.x] steps: - uses: actions/checkout@v1 - name: Use Node.js ${{ matrix.node }} diff --git a/package.json b/package.json index b40bb1e3d2..47b88d2b46 100644 --- a/package.json +++ b/package.json @@ -83,7 +83,7 @@ "vue-uuid": "^2.0.2" }, "engines": { - "node": ">=12.20 <14" + "node": ">=14.0 <16" }, "jest": { "moduleFileExtensions": [ From 43c9150532e72ea217471a2de0969ac62be765ee Mon Sep 17 00:00:00 2001 From: Adam DeHaven Date: Fri, 17 Dec 2021 15:52:50 -0500 Subject: [PATCH 2/5] fix(nvmrc): update nvmrc Update version in nvmrc. --- .nvmrc | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.nvmrc b/.nvmrc index f7fc567eee..ed9f5a0aff 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -12.22.5 \ No newline at end of file +14.18.2 diff --git a/package.json b/package.json index 47b88d2b46..6c7da672de 100644 --- a/package.json +++ b/package.json @@ -83,7 +83,7 @@ "vue-uuid": "^2.0.2" }, "engines": { - "node": ">=14.0 <16" + "node": ">=14.8.2 <15" }, "jest": { "moduleFileExtensions": [ From 0674dbcd9566115aa3a1a163b41a07c52e595aad Mon Sep 17 00:00:00 2001 From: Adam DeHaven Date: Fri, 17 Dec 2021 16:20:38 -0500 Subject: [PATCH 3/5] chore(actions): reference nvmrc in actions Utilize nvmrc node version value. --- .github/workflows/publish.yml | 16 ++++++++-------- .github/workflows/test.yml | 9 +++++---- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 7b5c049431..7314d8bc5f 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -9,15 +9,15 @@ on: jobs: test: runs-on: ubuntu-latest - strategy: - matrix: - node: [14.x] steps: - uses: actions/checkout@v2 - - name: Use Node.js ${{ matrix.node }} - uses: actions/setup-node@v1 + - name: Read .nvmrc + run: echo ::set-output name=NVMRC::$(cat .nvmrc) + id: nvm + - name: Use Node.js + uses: actions/setup-node@v2 with: - node-version: ${{ matrix.node }} + node-version: '${{ steps.nvm.outputs.NVMRC }}' - name: install and lint run: | yarn @@ -42,9 +42,9 @@ jobs: - uses: actions/checkout@v2 with: token: ${{ secrets.KONGPONENTS_BOT_PAT }} - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v2 with: - node-version: 14.x + node-version: '${{ steps.nvm.outputs.NVMRC }}' - name: setup git run: | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a4e0dafee1..31e8250b99 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -11,14 +11,15 @@ jobs: runs-on: ubuntu-latest strategy: fail-fast: false - matrix: - node: [14.x] steps: - uses: actions/checkout@v1 - - name: Use Node.js ${{ matrix.node }} + - name: Read .nvmrc + run: echo ::set-output name=NVMRC::$(cat .nvmrc) + id: nvm + - name: Use Node.js uses: actions/setup-node@v1 with: - node-version: ${{ matrix.node }} + node-version: '${{ steps.nvm.outputs.NVMRC }}' - name: install, lint run: | yarn install From d3b9e2ddd0563d6135f648215875f9fc1116695b Mon Sep 17 00:00:00 2001 From: Adam DeHaven Date: Fri, 17 Dec 2021 16:25:19 -0500 Subject: [PATCH 4/5] chore(actions): fix node variable Fix node variable in actions. --- .github/workflows/publish.yml | 4 ++-- .github/workflows/test.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 7314d8bc5f..de25f8d36e 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -12,8 +12,8 @@ jobs: steps: - uses: actions/checkout@v2 - name: Read .nvmrc - run: echo ::set-output name=NVMRC::$(cat .nvmrc) - id: nvm + run: echo '::set-output name=NVMRC::$(cat .nvmrc)' + id: nvm - name: Use Node.js uses: actions/setup-node@v2 with: diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 31e8250b99..1190f25ab5 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -14,8 +14,8 @@ jobs: steps: - uses: actions/checkout@v1 - name: Read .nvmrc - run: echo ::set-output name=NVMRC::$(cat .nvmrc) - id: nvm + run: echo '::set-output name=NVMRC::$(cat .nvmrc)' + id: nvm - name: Use Node.js uses: actions/setup-node@v1 with: From ab8568ee908c505e67ecb7f6d65e1571d7fb09af Mon Sep 17 00:00:00 2001 From: Adam DeHaven Date: Fri, 17 Dec 2021 16:27:57 -0500 Subject: [PATCH 5/5] chore(action): fix Fix the action. --- .github/workflows/publish.yml | 2 +- .github/workflows/test.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index de25f8d36e..a02d38fffe 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -12,7 +12,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Read .nvmrc - run: echo '::set-output name=NVMRC::$(cat .nvmrc)' + run: echo ::set-output name=NVMRC::$(cat .nvmrc) id: nvm - name: Use Node.js uses: actions/setup-node@v2 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1190f25ab5..6bd653c7c4 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -14,10 +14,10 @@ jobs: steps: - uses: actions/checkout@v1 - name: Read .nvmrc - run: echo '::set-output name=NVMRC::$(cat .nvmrc)' + run: echo ::set-output name=NVMRC::$(cat .nvmrc) id: nvm - name: Use Node.js - uses: actions/setup-node@v1 + uses: actions/setup-node@v2 with: node-version: '${{ steps.nvm.outputs.NVMRC }}' - name: install, lint