Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Player names under Locations incorrectly positioned when location name is long #1516

Open
rexy712 opened this issue Nov 16, 2024 · 1 comment

Comments

@rexy712
Copy link
Contributor

rexy712 commented Nov 16, 2024

Describe the bug
In the Location Bar, the player names are positioned too high when the name of the location is too long. If the text in the location name wraps, increasing the height of the location element, the added height is not accounted for in the positioning of the player names.

To Reproduce
Steps to reproduce the behavior:

  1. Create a location with a name long enough to cause text wrapping in the Location Bar.
  2. Add players to that location.
  3. Hit the drop down button on the 'Players' tab for the location.
  4. Player names overlap the location element.

Expected behavior
When the location name is short enough to not wrap, the player names are spaced evenly below the 'Players' tab. It should be the case as well for longer names.

Screenshots
The user names are ones I was testing with notes stuff before, so ignore their silliness
image

Desktop:

  • OS: gentoo linux
  • Browser: ungoogled-chromium 130.0.6723.58, firefox 132.0
  • Version: dev branch commit 62883f0

Additional Details
This isn't going to be a common issue since most location names are short enough to not wrap and/or there aren't enough locations to fill the whole screen. But it happened to me once now since I hadn't moved old locations into archive or deleted them.

I thought of creating a patch to limit the locations to one line of text as a minimal fix, but wasn't sure if that was the desired direction.

@develroo
Copy link

Ouch! That looks a bit like my issue with Asset names.

#1374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants