Skip to content

Commit

Permalink
[DATA-2210] Remove deprecated mql_query from TabularDataByMQLRequest (v…
Browse files Browse the repository at this point in the history
…iamrobotics#444)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
agreenb and github-actions[bot] authored Feb 6, 2024
1 parent 14d5df2 commit 838c3ce
Show file tree
Hide file tree
Showing 7 changed files with 455 additions and 497 deletions.
887 changes: 439 additions & 448 deletions app/data/v1/data.pb.go

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions component/generic/v1/generic.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions component/posetracker/v1/pose_tracker.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions gen/js/app/data/v1/data_pb.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -401,9 +401,6 @@ export class TabularDataByMQLRequest extends jspb.Message {
getOrganizationId(): string;
setOrganizationId(value: string): void;

getMqlQuery(): string;
setMqlQuery(value: string): void;

clearMqlBinaryList(): void;
getMqlBinaryList(): Array<Uint8Array | string>;
getMqlBinaryList_asU8(): Array<Uint8Array>;
Expand All @@ -424,7 +421,6 @@ export class TabularDataByMQLRequest extends jspb.Message {
export namespace TabularDataByMQLRequest {
export type AsObject = {
organizationId: string,
mqlQuery: string,
mqlBinaryList: Array<Uint8Array | string>,
}
}
Expand Down
30 changes: 0 additions & 30 deletions gen/js/app/data/v1/data_pb.js
Original file line number Diff line number Diff line change
Expand Up @@ -4065,7 +4065,6 @@ proto.viam.app.data.v1.TabularDataByMQLRequest.prototype.toObject = function(opt
proto.viam.app.data.v1.TabularDataByMQLRequest.toObject = function(includeInstance, msg) {
var f, obj = {
organizationId: jspb.Message.getFieldWithDefault(msg, 1, ""),
mqlQuery: jspb.Message.getFieldWithDefault(msg, 2, ""),
mqlBinaryList: msg.getMqlBinaryList_asB64()
};

Expand Down Expand Up @@ -4107,10 +4106,6 @@ proto.viam.app.data.v1.TabularDataByMQLRequest.deserializeBinaryFromReader = fun
var value = /** @type {string} */ (reader.readString());
msg.setOrganizationId(value);
break;
case 2:
var value = /** @type {string} */ (reader.readString());
msg.setMqlQuery(value);
break;
case 3:
var value = /** @type {!Uint8Array} */ (reader.readBytes());
msg.addMqlBinary(value);
Expand Down Expand Up @@ -4151,13 +4146,6 @@ proto.viam.app.data.v1.TabularDataByMQLRequest.serializeBinaryToWriter = functio
f
);
}
f = message.getMqlQuery();
if (f.length > 0) {
writer.writeString(
2,
f
);
}
f = message.getMqlBinaryList_asU8();
if (f.length > 0) {
writer.writeRepeatedBytes(
Expand Down Expand Up @@ -4186,24 +4174,6 @@ proto.viam.app.data.v1.TabularDataByMQLRequest.prototype.setOrganizationId = fun
};


/**
* optional string mql_query = 2;
* @return {string}
*/
proto.viam.app.data.v1.TabularDataByMQLRequest.prototype.getMqlQuery = function() {
return /** @type {string} */ (jspb.Message.getFieldWithDefault(this, 2, ""));
};


/**
* @param {string} value
* @return {!proto.viam.app.data.v1.TabularDataByMQLRequest} returns this
*/
proto.viam.app.data.v1.TabularDataByMQLRequest.prototype.setMqlQuery = function(value) {
return jspb.Message.setProto3StringField(this, 2, value);
};


/**
* repeated bytes mql_binary = 3;
* @return {!Array<string>}
Expand Down
5 changes: 3 additions & 2 deletions proto/viam/app/data/v1/data.proto
Original file line number Diff line number Diff line change
Expand Up @@ -203,12 +203,13 @@ message TabularDataBySQLResponse {
// TabularDataByMQLRequest requests tabular data using an MQL query.
message TabularDataByMQLRequest {
string organization_id = 1;
// mql_query is deprecated.
string mql_query = 2;
// mql_binary accepts a MongoDB aggregation pipeline as a list of BSON documents, where each
// document is one stage in the pipeline. The pipeline is run on the "sensorData.readings"
// namespace, which holds the Viam organization's tabular data.
repeated bytes mql_binary = 3;

reserved 2;
reserved "mql_query";
}

// TabularDataByMQLResponse provides unified tabular data and metadata, queried with MQL.
Expand Down
6 changes: 3 additions & 3 deletions service/slam/v1/slam.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 838c3ce

Please sign in to comment.