Skip to content

this._expressionProcessor.runCalculations called without await #203

Description

@cmoesel

The checkConstraints function calls this._expressionProcessor.runCalculations without awaiting it. Since runCalculations is asynchronous, this means that the rest of the checkConstraints logic may run without the latest runCalculations results.

To address this, checkConstraints should be changed to an async function so it can await the runCalculations call. If for some reason this is not necessary, and calling runCalculations without await is safe, then it should be documented via a code comment.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions