fix: Suppress embeds correctly

Author: Jiralite

src/index.ts

@@ -9,13 +9,16 @@
 
 import Discord, {
   ActivityType,
+  Client,
   Events,
   GatewayIntentBits,
   type Interaction,
+  Message,
   Partials,
 } from "discord.js";
 import CommandHandler from "@/commandHandler";
 import { env } from "@/config/env";
+import { suppressGitHubUnfurl } from "./util/suppressGitHubUnfurl";
 
 process.on("unhandledRejection", reason => {
   console.log("Unhandled Rejection:", reason);
@@ -24,8 +27,9 @@ process.on("unhandledRejection", reason => {
 const client = new Discord.Client({
   intents: [
     GatewayIntentBits.Guilds,
-    GatewayIntentBits.GuildMessages,
     GatewayIntentBits.GuildEmojisAndStickers,
+    GatewayIntentBits.GuildMessages,
+    GatewayIntentBits.MessageContent,
   ],
   partials: [Partials.Message, Partials.Channel, Partials.Reaction],
 });
@@ -61,24 +65,15 @@ client.on(Events.InteractionCreate, async (interaction: Interaction) => {
 client.on(Events.Error, e => {
   console.error("Discord client error!", e);
 });
-client.on(Events.MessageCreate, async message => {
-  if (message.author.bot) return;
-
-  message = await message.fetch();
 
-  for (const embed of message.embeds) {
-    if (!embed.url) continue;
-
-    const url = new URL(embed.url);
-    if (url.host !== "github.com") continue;
+// Message updates contain full data. Typings are corrected in a newer discord.js version.
+client.on(Events.MessageUpdate, async (_, newMessage) => {
+  await suppressGitHubUnfurl(newMessage as Message);
+});
 
-    const segments = url.pathname.split("/");
-    const githubUrlType: string | undefined = segments[3];
-    if (githubUrlType === "tree" || githubUrlType === "blob") {
-      await message.suppressEmbeds();
-      return;
-    }
-  }
+client.on(Events.MessageCreate, async (message: Message<boolean>) => {
+  if (message.author.bot) return;
+  await suppressGitHubUnfurl(message);
 });
 
 client.login(env.DISCORD_TOKEN);

src/util/suppressGitHubUnfurl.ts

@@ -0,0 +1,18 @@
+import { Message, MessageFlags } from "discord.js";
+
+export async function suppressGitHubUnfurl(message: Message) {
+  if (message.flags.has(MessageFlags.SuppressEmbeds)) return;
+
+  for (const embed of message.embeds) {
+    if (!embed.url) continue;
+    const url = new URL(embed.url);
+    if (url.host !== "github.com") continue;
+    const segments = url.pathname.split("/");
+    const githubUrlType: string | undefined = segments[3];
+
+    if (githubUrlType === "tree" || githubUrlType === "blob") {
+      await message.edit({ flags: message.flags.bitfield | MessageFlags.SuppressEmbeds });
+      return;
+    }
+  }
+}