Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Support [SecureContext] extended IDL attribute #1281

Open
ADKaster opened this issue Sep 4, 2024 · 0 comments
Open

LibWeb: Support [SecureContext] extended IDL attribute #1281

ADKaster opened this issue Sep 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ADKaster
Copy link
Member

ADKaster commented Sep 4, 2024

Many WebIDL interfaces define members that must only be accessed from a secure context.

We do not currently support this attribute, and it is ignored.

The IDL generator should be updated to add checks to ensure that these APIs are unavailable in a non-secure context. This likely involves an audit of all [SecureContext] web apis to make sure that we only define_native_accessor (or other define_native_xyz as applicable) for them when the relevant settings object is a secure context.

In order for this to not cause a mess for our in-tree tests, we'll also need an escape hatch in the Internals object to pretend like we're in a secure context for testing purposes.

@ADKaster ADKaster added the enhancement New feature or request label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant