deep sigh

Author: mackensen

.github/workflows/moodle-ci.yml

@@ -6,6 +6,9 @@ on:
     branches: [ 'main' ]
   schedule:
     - cron: '0 8 * * 1'
+defaults:
+  run:
+    shell: bash -l {0}
 jobs:
   test:
     strategy:
@@ -18,10 +21,10 @@ jobs:
         node-versions: ['14.15.0']
 
         exclude:
-          - {moodle-version: 'MOODLE_37_STABLE', php-versions: '7.4'}
+          - {moodle-version: 'MOODLE_37_STABLE', php-versions: '7.4', node-versions: '14.15.0'}
         include:
-          - {moodle-version: 'MOODLE_37_STABLE', php-versions: '7.1', operating-system: 'ubuntu-latest', database: 'mariadb'}
-          - {moodle-version: 'MOODLE_37_STABLE', php-versions: '7.1', operating-system: 'ubuntu-latest', database: 'pgsql'}
+          - {moodle-version: 'MOODLE_37_STABLE', php-versions: '7.1', node-versions: '14.15.0', operating-system: 'ubuntu-latest', database: 'mariadb'}
+          - {moodle-version: 'MOODLE_37_STABLE', php-versions: '7.1', node-versions: '14.15.0', operating-system: 'ubuntu-latest', database: 'pgsql'}
     runs-on: ${{ matrix.operating-system }}
     services:
       postgres:
@@ -52,10 +55,8 @@ jobs:
 
       - name: Install node
         run: |
-          nvm install $NODE_VERSION
-          nvm use $NODE_VERSION
-        env:
-          NODE_VERSION: ${{ matrix.node-versions }}
+          nvm install ${{ matrix.node-versions }}
+          nvm use ${{ matrix.node-versions }}
 
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
@@ -76,12 +77,11 @@ jobs:
 
       - name: Install Moodle
         run: |
-          nvm use $NODE_VERSION
-          moodle-plugin-ci install -vvv --plugin ./plugin --db-host=127.0.0.1 --node-version=$NODE_VERSION
+          nvm use ${{ matrix.node-versions }}
+          moodle-plugin-ci install -vvv --plugin ./plugin --db-host=127.0.0.1 --node-version=${{ matrix.node-versions }}
         env:
           DB: ${{ matrix.database }}
           MOODLE_BRANCH: ${{ matrix.moodle-version }}
-          NODE_VERSION: ${{ matrix.node-versions }}
 
       - name: phplint
         run: moodle-plugin-ci phplint