ci(windows): add MSVC 2022 Windows build + test job

Author: Lallapallooza

.github/workflows/ci.yml

@@ -199,6 +199,41 @@ jobs:
           UBSAN_OPTIONS: "halt_on_error=1:print_stacktrace=1"
         run: ctest --test-dir build --output-on-failure -j
 
+  windows-msvc:
+    name: windows-msvc-2022
+    runs-on: windows-2022
+    timeout-minutes: 25
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: CPM source cache
+        uses: actions/cache@v4
+        with:
+          path: ~/AppData/Local/.cache/CPM
+          key: cpm-windows-${{ hashFiles('cmake/CPM.cmake', 'cmake/GTestDep.cmake') }}
+          restore-keys: |
+            cpm-windows-
+
+      - name: Configure (MSVC, x64)
+        # The Visual Studio 2022 generator picks the MSVC toolchain by
+        # default and pulls in `cl.exe` through CMake's `vcvars` discovery.
+        # Bench is off (the peer-pool CPM pulls are Linux-only); tidy is
+        # off (no clang-tidy on this runner); tests are on.
+        env:
+          CPM_SOURCE_CACHE: ${{ github.workspace }}\.cache\CPM
+        run: |
+          cmake -S . -B build -G "Visual Studio 17 2022" -A x64 `
+            -DCITOR_BUILD_BENCHMARK=OFF `
+            -DCITOR_ENABLE_CLANG_TIDY=OFF
+
+      - name: Build (Release)
+        run: cmake --build build --config Release -j
+
+      - name: Test
+        # GoogleTest binaries land under build/tests/Release/ with the
+        # multi-config VS generator; ctest finds them automatically.
+        run: ctest --test-dir build -C Release --output-on-failure -j
+
   tsan-smoke:
     name: tsan (smoke)
     runs-on: ubuntu-24.04

README.md

@@ -11,8 +11,8 @@
 | Version | `0.2.2` |
 | Distribution | header-only |
 | CMake target | `citor::citor` (INTERFACE) |
-| Validated target | Linux x86_64 + AVX2; Windows x86_64 best-effort |
-| Compilers | GCC 14, Clang 18 (CI). MSVC 2022 on Windows (manual). |
+| Validated target | Linux x86_64 + AVX2; Windows x86_64 |
+| Compilers | GCC 14, Clang 18 (Linux). MSVC 2022 (Windows). All CI-backed. |
 | C++ standard | C++20 |
 | Runtime deps | `Threads::Threads` / pthread |
 | License | MIT |
@@ -1145,8 +1145,8 @@ Workload families in the bench tree:
 
 ## Supported targets
 
-- **Linux x86_64 + AVX2 (CI)**: Ubuntu 24.04 with GCC 14 and Clang 18, C++20. Every push on `main` runs the GTest suite, ASan + UBSan, TSan smoke, clang-tidy, and pre-commit hooks via `.github/workflows/ci.yml`. The latency contract is validated only on this configuration.
-- **Windows x86_64 (best-effort)**: MSVC 2022 with `/std:c++20`. Build and tests pass locally; no CI coverage. The Windows port maps each Linux primitive to its Win32 counterpart:
+- **Linux x86_64 + AVX2 (CI)**: Ubuntu 24.04 with GCC 14 and Clang 18, C++20. Every push on `main` runs the GTest suite, ASan + UBSan, TSan smoke, clang-tidy (diff-gated), and pre-commit hooks via `.github/workflows/ci.yml`. The latency contract is validated only on this configuration.
+- **Windows x86_64 (CI)**: Windows Server 2022 with MSVC 17 2022, `/std:c++20`. The `windows-msvc-2022` job builds the tree and runs the GTest suite. Latency numbers are not validated here; treat dispatch-floor measurements on Windows as indicative. The port maps each Linux primitive to its Win32 counterpart:
 
   | concern               | Win32 API                                              |
   |-----------------------|--------------------------------------------------------|
@@ -1157,7 +1157,7 @@ Workload families in the bench tree:
   | producer affinity     | `SetThreadAffinityMask`                                |
   | locked pages          | `VirtualLock`                                          |
 
-  The dispatch gate is a hybrid CAS plus `WaitOnAddress` lock on the cold path. Treat Windows numbers as indicative.
+  The dispatch gate is a hybrid CAS plus `WaitOnAddress` lock on the cold path.
 - **Packaging coverage in CI**:
 
   | install path                       | CI job                       |