fix: resolved all PR comments

sreecharan1306 · sreecharan1306 · commit cdb13dfd1e12 · 2026-05-02T08:04:57.000+05:30
diff --git a/kits/agentic/mockai/actions/orchestrate.ts b/kits/agentic/mockai/actions/orchestrate.ts
@@ -2,6 +2,7 @@
 
 import { lamaticClient } from "@/lib/lamatic-client"
 import { config } from "../orchestrate.js"
+import { z } from "zod"
 
 export async function generateQuestions(
   jobTitle: string,
@@ -27,16 +28,27 @@ export async function generateQuestions(
       jobDesc
     }
 
+    const inputSchema = z.object({
+      jobTitle: z.string().min(1, "Job title is required"),
+      yearsOfExp: z.number().min(0, "Years of experience must be a valid number"),
+      jobDesc: z.string().optional()
+    })
+
+    inputSchema.parse(inputs)
+
     // console.log(`[v0] Executing flow: ${flow.workflowId}`)
 
     const resData = await lamaticClient.executeFlow(flow.workflowId, inputs)
     // console.log("[v0] Flow execution completed")
 
-    const questions = resData?.result?.data
+    const responseSchema = z.object({
+      result: z.object({
+        data: z.array(z.string()).min(1, "No questions found in response")
+      })
+    })
 
-    if (!questions || !Array.isArray(questions) || questions.length === 0) {
-      throw new Error("No questions found in response")
-    }
+    const validatedResponse = responseSchema.parse(resData)
+    const questions = validatedResponse.result.data
 
     return {
       success: true,
@@ -46,7 +58,9 @@ export async function generateQuestions(
     console.error("[v0] Generation error:", error)
 
     let errorMessage = "Unknown error occurred"
-    if (error instanceof Error) {
+    if (error instanceof z.ZodError) {
+      errorMessage = "Validation error: Invalid data format."
+    } else if (error instanceof Error) {
       errorMessage = error.message
       if (error.message.includes("fetch failed")) {
         errorMessage =
@@ -84,30 +98,48 @@ export async function evaluateAnswers(
       candidateResponses
     }
 
+    const inputSchema = z.object({
+      candidateResponses: z.array(
+        z.object({
+          question: z.string(),
+          answers: z.string()
+        })
+      ).min(1, "At least one candidate response is required")
+    })
+
+    inputSchema.parse(inputs)
+
     // console.log(`[v0] Executing flow: ${flow.workflowId}`)
 
     const resData = await lamaticClient.executeFlow(flow.workflowId, inputs)
     console.log("[v0] Flow execution completed")
 
-    const result = resData?.result
+    const responseSchema = z.object({
+      result: z.object({
+        positives: z.array(z.string()).optional().default([]),
+        negatives: z.array(z.string()).optional().default([]),
+        rating: z.number()
+      })
+    })
 
-    if (!result || typeof result.rating !== 'number') {
-      throw new Error("No feedback found in response")
-    }
+    const validatedResponse = responseSchema.parse(resData)
+    const result = validatedResponse.result
 
     return {
       success: true,
       feedback: {
-        positives: result.positives || [],
-        negatives: result.negatives || [],
+        positives: result.positives,
+        negatives: result.negatives,
         rating: result.rating
       },
     }
   } catch (error) {
     console.error("[v0] Evaluation error:", error)
 
     let errorMessage = "Unknown error occurred"
-    if (error instanceof Error) {
+    if (error instanceof z.ZodError) {
+      errorMessage = "Validation error: Invalid data format."
+    } else if (error instanceof Error) {
       errorMessage = error.message
       if (error.message.includes("fetch failed")) {
         errorMessage =
diff --git a/kits/agentic/mockai/components/ui/sidebar.tsx b/kits/agentic/mockai/components/ui/sidebar.tsx
@@ -35,9 +35,9 @@ const SIDEBAR_KEYBOARD_SHORTCUT = 'b'
 type SidebarContextProps = {
   state: 'expanded' | 'collapsed'
   open: boolean
-  setOpen: (open: boolean) => void
+  setOpen: React.Dispatch<React.SetStateAction<boolean>>
   openMobile: boolean
-  setOpenMobile: (open: boolean) => void
+  setOpenMobile: React.Dispatch<React.SetStateAction<boolean>>
   isMobile: boolean
   toggleSidebar: () => void
 }
@@ -64,7 +64,7 @@ function SidebarProvider({
 }: React.ComponentProps<'div'> & {
   defaultOpen?: boolean
   open?: boolean
-  onOpenChange?: (open: boolean) => void
+  onOpenChange?: React.Dispatch<React.SetStateAction<boolean>>
 }) {
   const isMobile = useIsMobile()
   const [openMobile, setOpenMobile] = React.useState(false)
@@ -75,15 +75,22 @@ function SidebarProvider({
   const open = openProp ?? _open
   const setOpen = React.useCallback(
     (value: boolean | ((value: boolean) => boolean)) => {
-      const openState = typeof value === 'function' ? value(open) : value
+      const valueSetter = typeof value === 'function' ? value : () => value
+
       if (setOpenProp) {
-        setOpenProp(openState)
+        setOpenProp(valueSetter)
+
+        // This sets the cookie to keep the sidebar state.
+        document.cookie = `${SIDEBAR_COOKIE_NAME}=${valueSetter(open)}; path=/; max-age=${SIDEBAR_COOKIE_MAX_AGE}`
       } else {
-        _setOpen(openState)
-      }
+        _setOpen((prev) => {
+          const openState = valueSetter(prev)
 
-      // This sets the cookie to keep the sidebar state.
-      document.cookie = `${SIDEBAR_COOKIE_NAME}=${openState}; path=/; max-age=${SIDEBAR_COOKIE_MAX_AGE}`
+          // This sets the cookie to keep the sidebar state.
+          document.cookie = `${SIDEBAR_COOKIE_NAME}=${openState}; path=/; max-age=${SIDEBAR_COOKIE_MAX_AGE}`
+          return openState
+        })
+      }
     },
     [setOpenProp, open],
   )
diff --git a/kits/agentic/mockai/components/ui/tooltip.tsx b/kits/agentic/mockai/components/ui/tooltip.tsx
@@ -9,13 +9,7 @@ function TooltipProvider({
   delayDuration = 0,
   ...props
 }: React.ComponentProps<typeof TooltipPrimitive.Provider>) {
-  return (
-    <TooltipPrimitive.Provider
-      data-slot="tooltip-provider"
-      delayDuration={delayDuration}
-      {...props}
-    />
-  )
+  return <TooltipPrimitive.Root data-slot="tooltip" {...props} />
 }
 
 function Tooltip({
diff --git a/kits/agentic/mockai/config.json b/kits/agentic/mockai/config.json
@@ -1,22 +1,30 @@
 {
-    "name": "Generative AI",
-    "description": "Generate text, JSON, or images intelligently based on the given context.",
-    "tags": ["🤖 Agentic", "✨ Generative"],
+    "name": "Mockai - AI Interview Prep",
+    "description": "AI-powered mock interviewer that conducts dynamic interviews with real-time speech-to-text and provides instant feedback.",
+    "tags": [
+        "🤖 Agentic",
+        "🎤 Interview"
+    ],
     "author": {
         "name": "Lamatic AI",
         "email": "info@lamatic.ai"
     },
     "steps": [
         {
-            "id": "agentic-generate-content",
+            "id": "question-flow",
+            "type": "mandatory",
+            "envKey": "AGENTIC_QUESTION_FLOW_ID"
+        },
+        {
+            "id": "feedback-flow",
             "type": "mandatory",
-            "envKey": "AGENTIC_GENERATE_CONTENT"
+            "envKey": "AGENTIC_FEEDBACK_FLOW_ID"
         }
     ],
     "integrations": [],
     "features": [],
-    "demoUrl": "https://agent-kit-generation.vercel.app/",
-    "githubUrl": "https://github.com/Lamatic/AgentKit/tree/main/kits/agentic/generation",
-    "deployUrl": "https://vercel.com/new/clone?repository-url=https://github.com/Lamatic/AgentKit&root-directory=kits/agentic/generation&env=AGENTIC_GENERATE_CONTENT,LAMATIC_API_URL,LAMATIC_PROJECT_ID,LAMATIC_API_KEY&envDescription=Your%20Lamatic%20Generation%20keys%20are%20required.&envLink=https://lamatic.ai/templates/agentkits/agentic/agent-kit-generation",
-    "documentationUrl": "https://lamatic.ai/templates/agentkits/agentic/agent-kit-generation"
-}
+    "demoUrl": "https://agent-kit-mockai.vercel.app/",
+    "githubUrl": "https://github.com/Lamatic/AgentKit/tree/main/kits/agentic/mockai",
+    "deployUrl": "https://vercel.com/new/clone?repository-url=https://github.com/Lamatic/AgentKit&root-directory=kits/agentic/mockai&env=AGENTIC_QUESTION_FLOW_ID,AGENTIC_FEEDBACK_FLOW_ID,LAMATIC_API_URL,LAMATIC_PROJECT_ID,LAMATIC_API_KEY&envDescription=Your%20Lamatic%20MockAI%20keys%20are%20required.&envLink=https://lamatic.ai/templates/agentkits/agentic/agent-kit-mockai",
+    "documentationUrl": "https://lamatic.ai/templates/agentkits/agentic/agent-kit-mockai"
+}
