Merge pull request #22 from rcchopra/hyp-17516-v2

rishabh-arya95 · web-flow · commit 05f9d0786b4c · 2025-08-21T01:23:16.000+05:30
proxy support
diff --git a/scm/driver/github/github.go b/scm/driver/github/github.go
@@ -58,12 +58,14 @@ func NewWithProxy(uri, proxyURL string) (*scm.Client, error) {
 	client.Users = &userService{client}
 	client.Webhooks = &webhookService{client}
 	
+	client.Client.Client = &http.Client{Transport: http.DefaultTransport}
+
 	if proxyURL != "" {
 		transport, err := proxy.NewTransport(http.DefaultTransport, proxyURL)
 		if err != nil {
 			return nil, err
 		}
-		client.Client.Client = &http.Client{Transport: transport}
+		client.Client.Client.Transport = transport
 	}
 
 	return client.Client, nil

Original file line number	Diff line number	Diff line change
`@@ -58,12 +58,14 @@ func NewWithProxy(uri, proxyURL string) (*scm.Client, error) {`
`58`	`58`	`client.Users = &userService{client}`
`59`	`59`	`client.Webhooks = &webhookService{client}`
`60`	`60`
	`61`	`+ client.Client.Client = &http.Client{Transport: http.DefaultTransport}`
	`62`	`+`
`61`	`63`	`if proxyURL != "" {`
`62`	`64`	`transport, err := proxy.NewTransport(http.DefaultTransport, proxyURL)`
`63`	`65`	`if err != nil {`
`64`	`66`	`return nil, err`
`65`	`67`	`}`
`66`		`- client.Client.Client = &http.Client{Transport: transport}`
	`68`	`+ client.Client.Client.Transport = transport`
`67`	`69`	`}`
`68`	`70`
`69`	`71`	`return client.Client, nil`