Layr-Labs
diff --git a/‎.github/workflows/forge-coverage.yml
+72 b/‎.github/workflows/forge-coverage.yml
+72
diff --git a/‎.github/workflows/forge-fmt.yml
+30 b/‎.github/workflows/forge-fmt.yml
+30
diff --git a/‎.github/workflows/tests.yml
-3 b/‎.github/workflows/tests.yml
-3
diff --git a/‎Makefile
+2 b/‎Makefile
+2
diff --git a/‎README.md
+17-1 b/‎README.md
+17-1
diff --git a/‎bin/storage-report.sh
+45 b/‎bin/storage-report.sh
+45
diff --git a/‎docs/RegistryCoordinator.md
+3-3 b/‎docs/RegistryCoordinator.md
+3-3
diff --git a/‎docs/storage-report/AVSRegistrar.md
+6 b/‎docs/storage-report/AVSRegistrar.md
+6
diff --git a/‎docs/storage-report/BLSApkRegistry.md b/‎docs/storage-report/BLSApkRegistry.md
diff --git a/‎docs/storage-report/BLSApkRegistryStorage.md b/‎docs/storage-report/BLSApkRegistryStorage.md
diff --git a/‎docs/storage-report/BLSSignatureChecker.md b/‎docs/storage-report/BLSSignatureChecker.md
diff --git a/‎docs/storage-report/BLSSignatureCheckerStorage.md b/‎docs/storage-report/BLSSignatureCheckerStorage.md
diff --git a/‎docs/storage-report/ECDSAServiceManagerBase.md b/‎docs/storage-report/ECDSAServiceManagerBase.md
diff --git a/‎docs/storage-report/ECDSAStakeRegistry.md b/‎docs/storage-report/ECDSAStakeRegistry.md
diff --git a/‎docs/storage-report/ECDSAStakeRegistryEqualWeight.md b/‎docs/storage-report/ECDSAStakeRegistryEqualWeight.md
diff --git a/‎docs/storage-report/ECDSAStakeRegistryPermissioned.md b/‎docs/storage-report/ECDSAStakeRegistryPermissioned.md
diff --git a/‎docs/storage-report/ECDSAStakeRegistryStorage.md b/‎docs/storage-report/ECDSAStakeRegistryStorage.md
diff --git a/‎docs/storage-report/EjectionManager.md b/‎docs/storage-report/EjectionManager.md
diff --git a/‎docs/storage-report/EjectionManagerStorage.md b/‎docs/storage-report/EjectionManagerStorage.md
diff --git a/‎docs/storage-report/IndexRegistry.md b/‎docs/storage-report/IndexRegistry.md
diff --git a/‎docs/storage-report/IndexRegistryStorage.md b/‎docs/storage-report/IndexRegistryStorage.md
diff --git a/‎docs/storage-report/InstantSlasher.md b/‎docs/storage-report/InstantSlasher.md
diff --git a/‎docs/storage-report/OperatorStateRetriever.md b/‎docs/storage-report/OperatorStateRetriever.md
diff --git a/‎docs/storage-report/RegistryCoordinator.md b/‎docs/storage-report/RegistryCoordinator.md
diff --git a/‎docs/storage-report/RegistryCoordinatorStorage.md
+33 b/‎docs/storage-report/RegistryCoordinatorStorage.md
+33
diff --git a/‎docs/storage-report/ServiceManagerBase.md b/‎docs/storage-report/ServiceManagerBase.md
diff --git a/‎docs/storage-report/ServiceManagerBaseStorage.md
+19 b/‎docs/storage-report/ServiceManagerBaseStorage.md
+19
diff --git a/‎docs/storage-report/ServiceManagerRouter.md b/‎docs/storage-report/ServiceManagerRouter.md
diff --git a/‎docs/storage-report/SlasherBase.md b/‎docs/storage-report/SlasherBase.md
diff --git a/‎docs/storage-report/SlasherStorage.md b/‎docs/storage-report/SlasherStorage.md
diff --git a/‎docs/storage-report/SlashingRegistryCoordinator.md b/‎docs/storage-report/SlashingRegistryCoordinator.md
diff --git a/‎docs/storage-report/SlashingRegistryCoordinatorStorage.md b/‎docs/storage-report/SlashingRegistryCoordinatorStorage.md
diff --git a/‎docs/storage-report/SocketRegistry.md b/‎docs/storage-report/SocketRegistry.md
diff --git a/‎docs/storage-report/SocketRegistryStorage.md b/‎docs/storage-report/SocketRegistryStorage.md
diff --git a/‎docs/storage-report/StakeRegistry.md b/‎docs/storage-report/StakeRegistry.md
diff --git a/‎docs/storage-report/StakeRegistryStorage.md b/‎docs/storage-report/StakeRegistryStorage.md
diff --git a/‎docs/storage-report/VetoableSlasher.md b/‎docs/storage-report/VetoableSlasher.md
@@ -0,0 +1,72 @@
+name: Coverage
+
+on:
+  push:
+  workflow_dispatch: {}
+
+jobs:
+  run-coverage:
+    name: CI
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v2
+
+    - name: Load issue number
+      uses: actions/github-script@v6
+      id: get_issue_number
+      with:
+        script: |
+          const pullRequests = await github.rest.repos.listPullRequestsAssociatedWithCommit({
+            commit_sha: context.sha,
+            owner: context.repo.owner,
+            repo: context.repo.repo,
+          });
+
+          if (pullRequests.data.length > 0) {
+            return pullRequests.data[0].number;
+          } else {
+            throw new Error('No associated pull request found.');
+          }
+        result-encoding: string
+
+    - name: Install dependencies
+      run: |
+        sudo apt-get install lcov
+      id: lcov
+
+    - name: Install Foundry
+      uses: foundry-rs/foundry-toolchain@v1
+      with:
+        version: nightly
+
+    - name: Run coverage
+      run: FOUNDRY_PROFILE=ci forge coverage --report lcov
+      env:
+        RPC_MAINNET: ${{ secrets.RPC_MAINNET }}
+        RPC_HOLESKY: ${{ secrets.RPC_HOLESKY }}
+
+    - name: Prune coverage report
+      run: lcov --remove ./lcov.info -o ./lcov.info.pruned 'test/*' 'script/*' '*Storage.sol' --ignore-errors inconsistent
+
+    - name: Generate reports
+      run: genhtml -o report ./lcov.info.pruned
+
+    - name: Upload coverage results
+      uses: actions/upload-artifact@v4
+      with:
+        name: code-coverage-report
+        path: report/*
+
+    - name: View and log coverage
+      id: print_coverage
+      run: |
+        EOF=$(dd if=/dev/urandom bs=15 count=1 status=none | base64)
+        echo "comment_contents<<$EOF" >> $GITHUB_OUTPUT
+        echo "$(lcov --list ./lcov.info.pruned --ignore-errors inconsistent)" >> $GITHUB_OUTPUT
+        echo "$EOF" >> $GITHUB_OUTPUT
+    - name: Log Coverage Report
+      run: echo "${{ steps.print_coverage.outputs.comment_contents }}"
@@ -0,0 +1,30 @@
+name: Forge Fmt
+
+on:
+    workflow_dispatch:
+    push:
+      branches:
+        - master
+        - mainnet
+        - testnet-goerli
+        - dev
+    pull_request:
+
+jobs:
+  check:
+    name: CI
+    strategy:
+      fail-fast: true
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
+      - name: Install Foundry
+        uses: foundry-rs/foundry-toolchain@v1
+        with:
+          version: nightly
+      - name: Run forge fmt
+        run: |
+          forge fmt --check src
+        id: fmt
@@ -13,9 +13,6 @@ on:
       - dev
   pull_request:
 
-env:
-  FOUNDRY_PROFILE: ci
-
 jobs:
   check:
     strategy:
 
@@ -0,0 +1,2 @@
+storage-report:
+	bash ".github/bin/storage-report.sh" "docs/storage-report/"
@@ -15,6 +15,7 @@ EigenLayer is a set of smart contracts deployed on Ethereum that enable restakin
 ## Branching
 
 The main branches we use are:
+
 * [`dev (default)`](https://github.com/Layr-Labs/eigenlayer-middleware/tree/dev): The most up-to-date branch, containing the work-in-progress code for upcoming releases
 * [`testnet-holesky`](https://github.com/Layr-Labs/eigenlayer-middleware/tree/testnet-holesky): Our current testnet deployment
 * [`mainnet`](https://github.com/Layr-Labs/eigenlayer-middleware/tree/mainnet): Our current mainnet deployment
@@ -24,6 +25,7 @@ The main branches we use are:
 ### Basics
 
 To get a basic understanding of EigenLayer, check out [You Could've Invented EigenLayer](https://www.blog.eigenlayer.xyz/ycie/). Note that some of the document's content describes features that do not exist yet (like the Slasher). To understand more about how restakers and operators interact with EigenLayer, check out these guides:
+
 * [Restaking User Guide](https://docs.eigenlayer.xyz/restaking-guides/restaking-user-guide)
 * [Operator Guide](https://docs.eigenlayer.xyz/operator-guides/operator-introduction)
 
@@ -32,10 +34,25 @@ Most of this content is intro-level and describes user interactions with the Eig
 ### Deep Dive
 
 For shadowy super-coders:
+
 * The most up-to-date technical documentation can be found in [/docs](/docs).
 * To get an idea of how users interact with these contracts, check out the integration tests: [/test/integration](./test/integration)
 * To explore the EigenLayer core contracts, check out the core repo technical docs [here][core-docs-dev].
 
+### Note On Slashing
+
+The middleware contracts are available for testnet integration and experimentation. As with the rest of the testnet code, these contracts have not yet been fully audited. Internal security reviews are in progress, and we're preparing to engage external auditors. We're providing these now so AVSs can begin testing slashing conditions, Operator Sets, and related functionality, and so Operators can simulate slashing and test allocations. For more details, see [ELIP-002](https://github.com/eigenfoundation/ELIPs/blob/main/ELIPs/ELIP-002.md).
+
+For Operators:
+
+We provide scripts to deploy a mock service manager and allocate some stake to a mock Operator Set in [these scripts](https://github.com/Layr-Labs/eigenlayer-middleware/pull/335).
+We've reduced various safety delays on testnet to better simulate operational flows. Additional information on these delays is in [ELIP-002](https://github.com/eigenfoundation/ELIPs/blob/main/ELIPs/ELIP-002.md).
+For AVSs:
+
+We provide a migration path for existing M2 environments (LINK). While this requires understanding the provided script, the Developer Experience will improve before Mainnet launch. Note that this is a gradual migration process to new Operator Sets, not a direct upgrade of existing Operator Sets.
+We also provide scripts to spin up new service managers from scratch.
+In all cases, you’ll need to register existing Operators or spin up new Operators and allocate funds to them. These testing flows will improve as we refine the scripts and contracts. Stay tuned for updates, and feel free to reach out with any questions.
+
 ## Building and Running Tests
 
 This repository uses Foundry. See the [Foundry docs](https://book.getfoundry.sh/) for more info on installation and usage. If you already have foundry, you can build this project and run tests with these commands:
@@ -80,4 +97,3 @@ The current testnet deployment is on holesky, is from our M2 beta release. You c
 [`ServiceManagerRouter`](https://github.com/Layr-Labs/eigenlayer-middleware/blob/testnet-holesky/src/ServiceManagerRouter.sol) | - | [`0x4463...5a37`](https://holesky.etherscan.io/address/0x44632dfBdCb6D3E21EF613B0ca8A6A0c618F5a37#code) | |
 [`ProxyAdmin`](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v4.7.1/contracts/proxy/transparent/ProxyAdmin.sol) | - | [`0xB043...5c15`](https://holesky.etherscan.io/address/0xB043055dd967A382577c2f5261fA6428f2905c15) | |
 [`eigenda/EigenDAServiceManager`](https://github.com/Layr-Labs/eigenda/blob/a33b41561cc3fb4cd6d50a8738e4c5dca43ec0a5/contracts/src/core/EigenDAServiceManager.sol) | [`0xD4A7E1Bd8015057293f0D0A557088c286942e84b`](https://holesky.etherscan.io/address/0xD4A7E1Bd8015057293f0D0A557088c286942e84b) | [`0xa722...67f3`](https://holesky.etherscan.io/address/0xa7227485e6C693AC4566fe168C5E3647c5c267f3) | Proxy: [`[email protected]`](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v4.7.1/contracts/proxy/transparent/TransparentUpgradeableProxy.sol) |
-
 
@@ -0,0 +1,45 @@
+#!/bin/sh
+
+# Default output directory
+OUTPUT_DIR=${1:-docs/storage-report}
+
+# Function to print messages
+log() {
+    echo "$(date '+%Y-%m-%d %H:%M:%S') [INFO] $1"
+}
+
+# Function to print error messages
+error() {
+    echo "$(date '+%Y-%m-%d %H:%M:%S') [ERROR] $1" >&2
+}
+
+log "Starting the storage report generation."
+
+# Create the output directory if it doesn't exist
+if ! mkdir -p "$OUTPUT_DIR"; then
+    error "Failed to create output directory: $OUTPUT_DIR"
+    exit 1
+fi
+
+log "Output directory is set to: $OUTPUT_DIR"
+
+# Loop through Solidity files and generate storage report
+# NOTE: Ignores `src/interfaces` & `src/libraries` since they "should" not contain storage logic.
+for file in $(find src/ -name "*.sol" ! -path "*/interfaces/*" ! -path "*/libraries/*"); do
+    contract_name=$(basename "$file" .sol)
+    
+    # Check if the file exists and is readable
+    if [ ! -r "$file" ]; then
+        error "Cannot read file: $file"
+        continue
+    fi
+    
+    log "Processing contract: $contract_name"
+
+    # Run forge inspect and capture errors
+    if ! forge inspect "$contract_name" storage > "$OUTPUT_DIR/$contract_name.md"; then
+        error "Failed to generate storage report for contract: $contract_name"
+    else
+        log "Storage report generated for contract: $contract_name"
+    fi
+done
@@ -42,7 +42,7 @@ These methods allow operators to register for/deregister from one or more quorum
 function registerOperator(
     bytes calldata quorumNumbers,
     string calldata socket,
-    IBLSApkRegistry.PubkeyRegistrationParams calldata params,
+    IBLSApkRegistryTypes.PubkeyRegistrationParams calldata params,
     SignatureWithSaltAndExpiry memory operatorSignature
 ) 
     external 
@@ -88,7 +88,7 @@ If the Operator was not currently registered for any quorums, this method will r
 function registerOperatorWithChurn(
     bytes calldata quorumNumbers, 
     string calldata socket,
-    IBLSApkRegistry.PubkeyRegistrationParams calldata params,
+    IBLSApkRegistryTypes.PubkeyRegistrationParams calldata params,
     OperatorKickParam[] calldata operatorKickParams,
     SignatureWithSaltAndExpiry memory churnApproverSignature,
     SignatureWithSaltAndExpiry memory operatorSignature
@@ -256,7 +256,7 @@ These methods are used by the Owner to configure the `RegistryCoordinator`:
 function createQuorum(
     OperatorSetParam memory operatorSetParams,
     uint96 minimumStake,
-    IStakeRegistry.StrategyParams[] memory strategyParams
+    IStakeRegistryTypes.StrategyParams[] memory strategyParams
 ) 
     external
     virtual 
 
@@ -0,0 +1,6 @@
+
+╭------+------+------+--------+-------+----------╮
+| Name | Type | Slot | Offset | Bytes | Contract |
++================================================+
+╰------+------+------+--------+-------+----------╯
+
@@ -0,0 +1,33 @@
+
+╭-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------╮
+| Name                    | Type                                                                      | Slot | Offset | Bytes | Contract                                                      |
++=============================================================================================================================================================================================+
+| quorumCount             | uint8                                                                     | 0    | 0      | 1     | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| _quorumParams           | mapping(uint8 => struct ISlashingRegistryCoordinatorTypes.OperatorSetParam)       | 1    | 0      | 32    | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| _operatorBitmapHistory  | mapping(bytes32 => struct ISlashingRegistryCoordinatorTypes.QuorumBitmapUpdate[]) | 2    | 0      | 32    | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| _operatorInfo           | mapping(address => struct ISlashingRegistryCoordinatorTypes.OperatorInfo)         | 3    | 0      | 32    | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| isChurnApproverSaltUsed | mapping(bytes32 => bool)                                                  | 4    | 0      | 32    | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| quorumUpdateBlockNumber | mapping(uint8 => uint256)                                                 | 5    | 0      | 32    | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| registries              | address[]                                                                 | 6    | 0      | 32    | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| churnApprover           | address                                                                   | 7    | 0      | 20    | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| ejector                 | address                                                                   | 8    | 0      | 20    | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| lastEjectionTimestamp   | mapping(address => uint256)                                               | 9    | 0      | 32    | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| ejectionCooldown        | uint256                                                                   | 10   | 0      | 32    | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| isOperatorSetAVS        | bool                                                                      | 11   | 0      | 1     | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| isM2Quorum              | mapping(uint8 => bool)                                                    | 12   | 0      | 32    | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+|-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------|
+| __GAP                   | uint256[37]                                                               | 13   | 0      | 1184  | src/RegistryCoordinatorStorage.sol:RegistryCoordinatorStorage |
+╰-------------------------+---------------------------------------------------------------------------+------+--------+-------+---------------------------------------------------------------╯
+
@@ -0,0 +1,19 @@
+
+╭------------------+-------------+------+--------+-------+-------------------------------------------------------------╮
+| Name             | Type        | Slot | Offset | Bytes | Contract                                                    |
++======================================================================================================================+
+| _initialized     | uint8       | 0    | 0      | 1     | src/ServiceManagerBaseStorage.sol:ServiceManagerBaseStorage |
+|------------------+-------------+------+--------+-------+-------------------------------------------------------------|
+| _initializing    | bool        | 0    | 1      | 1     | src/ServiceManagerBaseStorage.sol:ServiceManagerBaseStorage |
+|------------------+-------------+------+--------+-------+-------------------------------------------------------------|
+| __gap            | uint256[50] | 1    | 0      | 1600  | src/ServiceManagerBaseStorage.sol:ServiceManagerBaseStorage |
+|------------------+-------------+------+--------+-------+-------------------------------------------------------------|
+| _owner           | address     | 51   | 0      | 20    | src/ServiceManagerBaseStorage.sol:ServiceManagerBaseStorage |
+|------------------+-------------+------+--------+-------+-------------------------------------------------------------|
+| __gap            | uint256[49] | 52   | 0      | 1568  | src/ServiceManagerBaseStorage.sol:ServiceManagerBaseStorage |
+|------------------+-------------+------+--------+-------+-------------------------------------------------------------|
+| rewardsInitiator | address     | 101  | 0      | 20    | src/ServiceManagerBaseStorage.sol:ServiceManagerBaseStorage |
+|------------------+-------------+------+--------+-------+-------------------------------------------------------------|
+| __GAP            | uint256[49] | 102  | 0      | 1568  | src/ServiceManagerBaseStorage.sol:ServiceManagerBaseStorage |
+╰------------------+-------------+------+--------+-------+-------------------------------------------------------------╯
+
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+storage-report:`
	`2`	`+ bash ".github/bin/storage-report.sh" "docs/storage-report/"`