From 0e24eb7191cf6430c14e18394582efc39dcbb9b3 Mon Sep 17 00:00:00 2001 From: LeticiadelaOsa Date: Tue, 19 Dec 2023 13:56:39 +0100 Subject: [PATCH 1/3] about-me section --- export-samples/html/cv-monochrome-force.html | 3 +++ .../html-parts/about-me-section/about-me-section.ejs | 2 +- .../html-parts/about-me-section/about-me-section.part.ts | 2 ++ .../html-parts/html-document-start/html-document-start.ejs | 3 +++ 4 files changed, 9 insertions(+), 1 deletion(-) diff --git a/export-samples/html/cv-monochrome-force.html b/export-samples/html/cv-monochrome-force.html index be4c8b3b..fc3f3b1c 100644 --- a/export-samples/html/cv-monochrome-force.html +++ b/export-samples/html/cv-monochrome-force.html @@ -337,6 +337,9 @@ } /* section about */ + .about p + p { + margin-top: var(--space-8); + } @media screen and (min-width: 834px) { .about { font-size: var(--fs-l); diff --git a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/about-me-section/about-me-section.ejs b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/about-me-section/about-me-section.ejs index 821c9700..39a48102 100644 --- a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/about-me-section/about-me-section.ejs +++ b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/about-me-section/about-me-section.ejs @@ -1,6 +1,6 @@ <%_ if (profile.description && profile.description !== 'undefined' ) { -%>

<%- labels.ABOUT_ME_HEADING %>

-

<%= profile.description %>

+ <%- mapMarkdownToHTML(profile.description) %>
<%_ } -%> \ No newline at end of file diff --git a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/about-me-section/about-me-section.part.ts b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/about-me-section/about-me-section.part.ts index 9903d5e9..d3f17a17 100644 --- a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/about-me-section/about-me-section.part.ts +++ b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/about-me-section/about-me-section.part.ts @@ -4,6 +4,7 @@ import { ISO_SPANISH_LANGUAGE } from '@/engine/engine.const'; import { ManfredAwesomicCV, Settings, Language } from '@/model'; import { getLabels } from './labels'; import aboutMeSection from './about-me-section.ejs?raw'; +import { mapMarkdownToHTML } from '@/mappers'; export const generateAboutMeSection = (cv: ManfredAwesomicCV, settings: Settings): string => { const profileSectionVm = mapFromMacCvToProfileSectionVm(cv); @@ -18,6 +19,7 @@ const generateAboutMeSectionInner = ( const rootObject = { profile: profileSectionVm, labels: getLabels(language), + mapMarkdownToHTML, }; return ejs.render(aboutMeSection, rootObject); }; diff --git a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/html-document-start/html-document-start.ejs b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/html-document-start/html-document-start.ejs index 8286894f..30709ddf 100644 --- a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/html-document-start/html-document-start.ejs +++ b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/html-document-start/html-document-start.ejs @@ -337,6 +337,9 @@ } /* section about */ + .about p + p { + margin-top: var(--space-8); + } @media screen and (min-width: 834px) { .about { font-size: var(--fs-l); From b2feb77955880baa06688cdf75b131a51e34a9dc Mon Sep 17 00:00:00 2001 From: LeticiadelaOsa Date: Wed, 20 Dec 2023 12:36:13 +0100 Subject: [PATCH 2/3] use mapMarkdownToHTML in about-me and experience section, and update styles --- export-samples/html/cv-monochrome-force.html | 36 ++++++++++++------- .../about-me-section/about-me-section.ejs | 2 +- .../experience-section/experience-section.ejs | 2 +- .../experience-section.part.ts | 2 ++ .../html-document-start.ejs | 10 +++++- 5 files changed, 36 insertions(+), 16 deletions(-) diff --git a/export-samples/html/cv-monochrome-force.html b/export-samples/html/cv-monochrome-force.html index fc3f3b1c..580f9ef6 100644 --- a/export-samples/html/cv-monochrome-force.html +++ b/export-samples/html/cv-monochrome-force.html @@ -337,7 +337,7 @@ } /* section about */ - .about p + p { + .about__text > * + * { margin-top: var(--space-8); } @media screen and (min-width: 834px) { @@ -522,6 +522,13 @@ .experience__text { font-weight: var(--fw-light); } + .experience__text ul, + .experience__text ol { + padding-left: var(--space-24); + } + .experience__text * + * { + margin-top: var(--space-base); + } .experience__url { display: block; font-size: var(--fs-xs); @@ -536,6 +543,7 @@ font-weight: var(--fw-medium); color: var(--primary-600); margin-bottom: var(--space-16); + margin-top: var(--space-base); } .experience__tools-list { padding: 0; @@ -816,18 +824,20 @@

Mis Enlaces

Sobre mi

-

- Llevo casi dos décadas desarrollando software, ocupando puestos a lo largo de toda la cadena de valor - -programacion, diseño de producto, marketing, ventas y gestión de equipos, departamentos y empresas- pero creo - que el rol donde se cruzan mi vocación, mis habilidades y las necesidades de la mayoría de las empresas es en - la gestión de equipos y proyectos de construcción de activos digitales. Me apasiona contribuir en todo el - ciclo de vida de un producto o servicio informático, desde la definición hasta el mantenimiento o soporte a - clientes, y también involucrarme en la comercialización del mismo. Me gusta trabajar con gente y para la - gente. Como responsable de equipos, mi principal prioridad siempre es eliminar cualquier problema que les - impida alcanzar todo su potencial. También procuro devolver a la Comunidad informática parte del valor y el - conocimiento que me han aportado a lo largo de mi carrera profesional, dando charlas o colaborando con grupos - de usuarios y conferencias técnicas; y, a veces, organizándolos. -

+
+

+ Llevo casi dos décadas desarrollando software, ocupando puestos a lo largo de toda la cadena de valor + -programacion, diseño de producto, marketing, ventas y gestión de equipos, departamentos y empresas- pero + creo que el rol donde se cruzan mi vocación, mis habilidades y las necesidades de la mayoría de las empresas + es en la gestión de equipos y proyectos de construcción de activos digitales. Me apasiona contribuir en todo + el ciclo de vida de un producto o servicio informático, desde la definición hasta el mantenimiento o soporte + a clientes, y también involucrarme en la comercialización del mismo. Me gusta trabajar con gente y para la + gente. Como responsable de equipos, mi principal prioridad siempre es eliminar cualquier problema que les + impida alcanzar todo su potencial. También procuro devolver a la Comunidad informática parte del valor y el + conocimiento que me han aportado a lo largo de mi carrera profesional, dando charlas o colaborando con + grupos de usuarios y conferencias técnicas; y, a veces, organizándolos. +

+

Habilidades

diff --git a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/about-me-section/about-me-section.ejs b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/about-me-section/about-me-section.ejs index 39a48102..44a86e7a 100644 --- a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/about-me-section/about-me-section.ejs +++ b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/about-me-section/about-me-section.ejs @@ -1,6 +1,6 @@ <%_ if (profile.description && profile.description !== 'undefined' ) { -%>

<%- labels.ABOUT_ME_HEADING %>

- <%- mapMarkdownToHTML(profile.description) %> +
<%- mapMarkdownToHTML(profile.description) %>
<%_ } -%> \ No newline at end of file diff --git a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/experience-section/experience-section.ejs b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/experience-section/experience-section.ejs index 447def79..fe9c06f1 100644 --- a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/experience-section/experience-section.ejs +++ b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/experience-section/experience-section.ejs @@ -16,7 +16,7 @@ <%_ if(experience.roles[0].challenges && experience.roles[0].challenges.length !== 0) { -%>
<%_ for(const challenge of experience.roles[0].challenges){ -%> -

<%- challenge.description %>

+ <%- mapMarkdownToHTML(challenge.description) %> <%_}-%>
<%_}-%> diff --git a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/experience-section/experience-section.part.ts b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/experience-section/experience-section.part.ts index 32a85bd8..276e9685 100644 --- a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/experience-section/experience-section.part.ts +++ b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/experience-section/experience-section.part.ts @@ -4,6 +4,7 @@ import { Settings, Language, ManfredAwesomicCV } from '@/model'; import { ISO_SPANISH_LANGUAGE } from '@/engine/engine.const'; import experienceTemplate from './experience-section.ejs?raw'; import { getLabels } from './labels'; +import { mapMarkdownToHTML } from '@/mappers'; export const generateExperiencesSection = (cv: ManfredAwesomicCV, settings: Settings): string => { const experienceSectionVm = mapFromMacCvToExperienceSectionVm(cv); @@ -18,6 +19,7 @@ const generateExperienceSectionInner = ( const rootObject = { experienceCollection: experienceSectionVm, labels: getLabels(language), + mapMarkdownToHTML, }; return ejs.render(experienceTemplate, rootObject); diff --git a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/html-document-start/html-document-start.ejs b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/html-document-start/html-document-start.ejs index 30709ddf..918736fc 100644 --- a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/html-document-start/html-document-start.ejs +++ b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/html-document-start/html-document-start.ejs @@ -337,7 +337,7 @@ } /* section about */ - .about p + p { + .about__text > * + * { margin-top: var(--space-8); } @media screen and (min-width: 834px) { @@ -522,6 +522,13 @@ .experience__text { font-weight: var(--fw-light); } + .experience__text ul, .experience__text ol{ + padding-left: var(--space-24); + } + .experience__text * + *{ + margin-top: var(--space-base); + } + .experience__url { display: block; font-size: var(--fs-xs); @@ -536,6 +543,7 @@ font-weight: var(--fw-medium); color: var(--primary-600); margin-bottom: var(--space-16); + margin-top: var(--space-base); } .experience__tools-list { padding: 0; From a04b4eee4768927131fd9a8bf4f4afb2a78ebbc3 Mon Sep 17 00:00:00 2001 From: LeticiadelaOsa Date: Wed, 20 Dec 2023 12:46:32 +0100 Subject: [PATCH 3/3] remove the selector directly so that, in case there are nested elements, they are spaced --- export-samples/html/cv-monochrome-force.html | 2 +- .../html-parts/html-document-start/html-document-start.ejs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/export-samples/html/cv-monochrome-force.html b/export-samples/html/cv-monochrome-force.html index 580f9ef6..36c06d05 100644 --- a/export-samples/html/cv-monochrome-force.html +++ b/export-samples/html/cv-monochrome-force.html @@ -337,7 +337,7 @@ } /* section about */ - .about__text > * + * { + .about__text * + * { margin-top: var(--space-8); } @media screen and (min-width: 834px) { diff --git a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/html-document-start/html-document-start.ejs b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/html-document-start/html-document-start.ejs index 918736fc..8ab39e5a 100644 --- a/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/html-document-start/html-document-start.ejs +++ b/packages/manfred2html/src/engine/cv-monochrome-force/html-parts/html-document-start/html-document-start.ejs @@ -337,7 +337,7 @@ } /* section about */ - .about__text > * + * { + .about__text * + * { margin-top: var(--space-8); } @media screen and (min-width: 834px) {