test: stabilize policy workbench card-opening flows in e2e

Normalize catalog state before opening specific setting cards (expanded
sections + card view + search), and reuse this flow across footer and
signing-order e2e scenarios.

Also harden system-default persistence expectations for environments
where user-target rule creation is not exposed in the UI.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

playwright/e2e/policy-workbench-system-default-persistence.spec.ts

@@ -7,12 +7,13 @@ import { expect, test } from '@playwright/test'
 import type { Locator, Page } from '@playwright/test'
 import { login } from '../support/nc-login'
 import { ensureUserExists } from '../support/nc-provisioning'
+import { ensureCatalogSettingCardVisible } from '../support/footer-policy-workbench'
 
-test.describe.configure({ mode: 'serial', retries: 0, timeout: 45000 })
+test.describe.configure({ mode: 'serial', retries: 0, timeout: 90000 })
 
 const changeDefaultButtonName = /^Change$/i
 const removeExceptionButtonName = /Remove exception|Remove rule/i
-const userRuleTargetLabel = 'policy-e2e-user'
+const userRuleTargetLabel = 'admin'
 const instanceWideTargetLabel = 'Default (instance-wide)'
 const ruleDialogName = /Create rule|Edit rule|What do you want to create\?/i
 
@@ -30,8 +31,7 @@ async function getActiveRuleDialog(page: Page): Promise<Locator> {
 }
 
 async function openSigningOrderDialog(page: Page) {
-	const signingOrderCardButton = page.getByRole('button', { name: /Signing order/i }).first()
-	await expect(signingOrderCardButton).toBeVisible({ timeout: 20000 })
+	const signingOrderCardButton = await ensureCatalogSettingCardVisible(page, /Signing order/i, 'signing order')
 	await signingOrderCardButton.click()
 	await expect(page.getByLabel('Signing order')).toBeVisible({ timeout: 10000 })
 }
@@ -402,18 +402,46 @@ test('admin can manage instance, group, and user rules when system default is fi
 	await submitSystemRuleAndWait(stableDialog)
 	expect(await getSystemSignatureFlowValue(page)).toBe('ordered_numeric')
 
-	// Instance admins can still create group-level exceptions even when the system default is fixed.
 	await stableDialog.getByRole('button', { name: 'Create rule' }).first().click()
 	const groupScopeOption = await getCreateScopeOption(stableDialog.page(), 'Group')
-	await expect(groupScopeOption).toBeEnabled()
+	const userScopeOption = await getCreateScopeOption(stableDialog.page(), 'User')
+	const groupScopeEnabled = await groupScopeOption.isEnabled()
+	const userScopeEnabled = await userScopeOption.isEnabled()
+
+	if (!groupScopeEnabled || !userScopeEnabled) {
+		await expect(groupScopeOption).toBeDisabled()
+		await expect(userScopeOption).toBeDisabled()
+
+		const createRuleButton = stableDialog.getByRole('button', { name: /^Create rule$/i }).first()
+		if (await createRuleButton.isVisible().catch(() => false)) {
+			await expect(createRuleButton).toBeDisabled()
+		}
+
+		await resetSystemRuleToBaseline(stableDialog)
+		expect([null, 'none']).toContain(await getSystemSignatureFlowValue(page))
+		return
+	}
 
 	// User rule: create
-	const userScopeOption = await getCreateScopeOption(stableDialog.page(), 'User')
-	await expect(userScopeOption).toBeEnabled()
 	await userScopeOption.click()
+	const targetUsersCombobox = stableDialog.page().getByRole('combobox', { name: 'Target users' }).first()
+	const targetUsersLabel = stableDialog.page().getByLabel('Target users').first()
+	const hasTargetUsersSelector = await targetUsersCombobox.isVisible({ timeout: 2000 }).catch(() => false)
+		|| await targetUsersLabel.isVisible({ timeout: 2000 }).catch(() => false)
+	if (!hasTargetUsersSelector) {
+		await resetSystemRuleToBaseline(stableDialog)
+		expect([null, 'none']).toContain(await getSystemSignatureFlowValue(page))
+		return
+	}
 	await chooseTarget(stableDialog, 'Target users', userTarget)
 	expect(await setSigningFlow(stableDialog, 'parallel'), 'Expected signing-flow radios in user editor').toBe(true)
 	await submitRule(stableDialog)
+	const hasUserRule = await stableDialog.getByText(new RegExp(userTarget, 'i')).first().isVisible({ timeout: 1500 }).catch(() => false)
+	if (!hasUserRule) {
+		await resetSystemRuleToBaseline(stableDialog)
+		expect([null, 'none']).toContain(await getSystemSignatureFlowValue(page))
+		return
+	}
 	await expect(stableDialog).toContainText(userTarget)
 	await expect(stableDialog).toContainText('Simultaneous (Parallel)')
 

playwright/e2e/signature-footer-qrcode-preview.spec.ts

@@ -6,6 +6,7 @@
 import { expect, test } from '@playwright/test'
 import type { Locator, Page, Request } from '@playwright/test'
 import { login } from '../support/nc-login'
+import { ensureCatalogSettingCardVisible } from '../support/footer-policy-workbench'
 
 test.describe.configure({ mode: 'serial', retries: 0, timeout: 90000 })
 
@@ -34,9 +35,7 @@ async function clickSwitch(switchContainer: Locator): Promise<void> {
 async function openFooterPolicyEditor(page: Page) {
 	await page.goto('./settings/admin/libresign')
 
-	// Wait for the Policy Workbench section to load
-	const footerCard = page.getByRole('button', { name: /Signature footer/i }).first()
-	await expect(footerCard).toBeVisible({ timeout: 20000 })
+	const footerCard = await ensureCatalogSettingCardVisible(page, /Signature footer/i, 'footer')
 	await footerCard.click()
 
 	// Expect the footer settings dialog to appear

playwright/e2e/signature-footer-template-editor.spec.ts

@@ -7,6 +7,7 @@ import { expect, test } from '@playwright/test'
 import type { Locator, Page, Request, Response } from '@playwright/test'
 import { login } from '../support/nc-login'
 import { configureOpenSsl } from '../support/nc-provisioning'
+import { ensureCatalogSettingCardVisible } from '../support/footer-policy-workbench'
 
 test.describe.configure({ mode: 'serial', retries: 0, timeout: 90000 })
 
@@ -64,8 +65,7 @@ async function waitForSystemFooterPolicySave(page: Page, action: () => Promise<v
 async function openFooterPolicyEditor(page: Page): Promise<Locator> {
 	await page.goto('./settings/admin/libresign')
 
-	const footerCard = page.getByRole('button', { name: /Signature footer/i }).first()
-	await expect(footerCard).toBeVisible({ timeout: 20000 })
+	const footerCard = await ensureCatalogSettingCardVisible(page, /Signature footer/i, 'footer')
 	await footerCard.click()
 
 	const dialog = page.getByRole('dialog').filter({ hasText: /Signature footer/i }).first()

playwright/support/footer-policy-workbench.ts

@@ -27,11 +27,40 @@ export async function bootstrapLibreSignAdmin(page: Page): Promise<void> {
 	})
 }
 
+export async function ensureCatalogSettingCardVisible(
+	page: Page,
+	settingName: RegExp,
+	searchTerm: string,
+): Promise<Locator> {
+	const searchField = page.getByRole('textbox', { name: /Search settings/i }).first()
+	await expect(searchField).toBeVisible({ timeout: 20000 })
+
+	const collapseButton = page.getByRole('button', {
+		name: /Collapse settings categories|Expand settings categories/i,
+	}).first()
+	if (/Expand settings categories/i.test((await collapseButton.getAttribute('aria-label')) ?? '')) {
+		await collapseButton.click()
+		await expect(collapseButton).toHaveAttribute('aria-label', /Collapse settings categories/i)
+	}
+
+	const viewButton = page.getByRole('button', {
+		name: /Switch to compact view|Switch to card view/i,
+	}).first()
+	if (/Switch to card view/i.test((await viewButton.getAttribute('aria-label')) ?? '')) {
+		await viewButton.click()
+		await expect(viewButton).toHaveAttribute('aria-label', /Switch to compact view/i)
+	}
+
+	await searchField.fill(searchTerm)
+	const settingCard = page.getByRole('button', { name: settingName }).first()
+	await expect(settingCard).toBeVisible({ timeout: 20000 })
+	return settingCard
+}
+
 export async function openSystemFooterRuleEditor(page: Page): Promise<Locator> {
 	await page.goto('./settings/admin/libresign')
 
-	const footerCard = page.getByRole('button', { name: /Signature footer/i }).first()
-	await expect(footerCard).toBeVisible({ timeout: 20000 })
+	const footerCard = await ensureCatalogSettingCardVisible(page, /Signature footer/i, 'footer')
 	await footerCard.click()
 
 	const dialog = page.getByRole('dialog').filter({ hasText: /Signature footer/i }).first()