Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catching also PL deprecation warnigs #24

Open
Borda opened this issue Jan 12, 2022 · 1 comment
Open

catching also PL deprecation warnigs #24

Borda opened this issue Jan 12, 2022 · 1 comment
Labels
CI/CD Continues Integration / delivery enhancement New feature or request RFC Ready for Comments

Comments

@Borda
Copy link
Member

Borda commented Jan 12, 2022

🚀 Feature

if we want to be progressive incompatibility we shall also report on deprecation warnings and eventually treat them as failer...
as an alternative, we can give a user option to set it as strict 🤔

Pitch

Compatibility for the future

Alternatives

pass pytest argument -W error::DeprecationWarning in
https://github.com/PyTorchLightning/ecosystem-ci/blob/c544b7bc10fbef6f6b498805dd08837eb1ba96a2/actions/_config.yaml#L54

Additional context

https://docs.pytest.org/en/latest/how-to/capture-warnings.html#controlling-warnings

@Borda Borda added the enhancement New feature or request label Jan 12, 2022
@rohitgr7
Copy link
Contributor

rohitgr7 commented Jan 12, 2022

to just catch the deprecation warnings as an error, we need to somehow catch LightningDeprecationWarning from pytorch-lightning.

Just like:
https://github.com/PyTorchLightning/pytorch-lightning/blob/00d1758bac69d55e934e43f3961ba328a2b8951e/setup.cfg#L27-L29

but here pytorch-lightning is an external package, so we need to figure out how we can do that.

@Borda Borda added the CI/CD Continues Integration / delivery label Jan 24, 2022
@Borda Borda added the RFC Ready for Comments label Feb 13, 2022
@stale stale bot added the wontfix This will not be worked on label Apr 16, 2022
@Lightning-AI Lightning-AI deleted a comment from stale bot Apr 16, 2022
@stale stale bot removed the wontfix This will not be worked on label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continues Integration / delivery enhancement New feature or request RFC Ready for Comments
Projects
None yet
Development

No branches or pull requests

2 participants