Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda environment for specific dependencies #39

Open
titu1994 opened this issue Feb 11, 2022 · 1 comment
Open

Conda environment for specific dependencies #39

titu1994 opened this issue Feb 11, 2022 · 1 comment
Labels
CI/CD Continues Integration / delivery enhancement New feature or request help wanted Extra attention is needed let's do it

Comments

@titu1994
Copy link

🚀 Feature

While the current container tests are run against bare python, there are many important libraries that require conda to be available to properly install dependencies. Therefore conda support would be the request.

Motivation

A use case for this in NeMo is Numba - we utilize it for custom CUDA kernels for RNNT loss, custom spec augment kernels and in the future for jit compiled CPU code as well. We have plenty of unit tests that are optional (and hence skipped) when these are not installed.

Another is Pynini (for WFST based text normalization and inverse text normalization) - however since the graph building takes significant time if not cached, we do not recommend performing this CPU test during your ecosystem tests. It is just an example.

The reason we prefer Numba to be installed from conda (whereas it does have a pip install path) is that often an increment in numba version is accompanied by an increment in the llvmlite library too - and this causes significant issues. llvmlite is a library that will often throw errors during upgrade, and it can be forced via --force-reinstall (for pip) but that brings about an unstable environment. Conda bypasses all of this.

Pitch

Install miniconda on the fly (or use a base container that supports conda).

Alternatives

Leave conda tests out, and request ecosystem members to make their tests skippable if dependencies are not installed. NeMo can do this (and currently does skip numba tests if its not installed or doesn't support a recent cuda version), it may be cumbersome on a large scale.

@titu1994 titu1994 added the enhancement New feature or request label Feb 11, 2022
@Borda Borda added CI/CD Continues Integration / delivery help wanted Extra attention is needed labels Feb 13, 2022
@Borda
Copy link
Member

Borda commented Feb 13, 2022

I see this as a very feasible request and I hear it already from the inside PL team... 🐰

@stale stale bot added the wontfix This will not be worked on label Apr 16, 2022
@Lightning-AI Lightning-AI deleted a comment from stale bot Apr 16, 2022
@stale stale bot removed the wontfix This will not be worked on label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continues Integration / delivery enhancement New feature or request help wanted Extra attention is needed let's do it
Projects
None yet
Development

No branches or pull requests

2 participants