Skip to content

Add learning rate scheduling support for DeepSpeedStrategy #20320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Jun 27, 2025
Merged

Add learning rate scheduling support for DeepSpeedStrategy #20320

merged 45 commits into from
Jun 27, 2025

Conversation

amorehead
Copy link
Contributor

@amorehead amorehead commented Oct 5, 2024 •
edited
Loading

What does this PR do?

  • Adds learning rate scheduling support for DeepSpeedStrategy
  • Credit to lvhoaa for suggesting this change to make Fabric's support for internal DeepSpeed features even more robust
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs) N
  • x ] Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20320.org.readthedocs.build/en/20320/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Oct 5, 2024
@lantiga
Copy link
Collaborator

lantiga commented Oct 7, 2024

Thanks for the contribution @amorehead! Let's get to a green CI and take it from there

@lantiga
Copy link
Collaborator

lantiga commented Nov 12, 2024

hey @amorehead looks like CI failures are legit, let me know if you can fix those

@lantiga lantiga added the waiting on author Waiting on user action, correction, or update label Nov 12, 2024
@github-actions github-actions bot added the docs Documentation related label Jan 10, 2025
@Borda
Copy link
Member

Borda commented Mar 14, 2025

@amorehead mind check the last failng case:

FAILED strategies/test_model_parallel.py::test_parallelize_fn_call - ValueError: too many values to unpack (expected 2)

@amorehead
Copy link
Contributor Author

@Borda, I've just fixed this test

@Borda
Copy link
Member

Borda commented Mar 17, 2025

@Borda, I've just fixed this test

seems one left:

FAILED strategies/test_deepspeed.py::test_deepspeed_setup_module - AssertionError: expected call not found.
Expected: initialize(args=<ANY>, config={'activation_checkpointing': {'partition_activations': False, 'cpu_checkpointing': False, 'contiguous_memory_optimization': False, 'synchronize_checkpoint_boundary': False}, 'aio': {'block_size': 1048576, 'queue_depth': 8, 'single_submit': False, 'overlap_events': True, 'thread_count': 1}, 'zero_allow_untested_optimizer': True, 'zero_optimization': {'stage': 2, 'contiguous_gradients': True, 'overlap_comm': True, 'allgather_partitions': True, 'reduce_scatter': True, 'allgather_bucket_size': 200000000, 'reduce_bucket_size': 200000000, 'sub_group_size': 1000000000000}}, model=<Mock id='140346019654640'>, model_parameters=<ANY>, optimizer=None, dist_init_required=False)
Actual: initialize(args=Namespace(device_rank=1), config={'activation_checkpointing': {'partition_activations': False, 'cpu_checkpointing': False, 'contiguous_memory_optimization': False, 'synchronize_checkpoint_boundary': False}, 'aio': {'block_size': 1048576, 'queue_depth': 8, 'single_submit': False, 'overlap_events': True, 'thread_count': 1}, 'zero_allow_untested_optimizer': True, 'zero_optimization': {'stage': 2, 'contiguous_gradients': True, 'overlap_comm': True, 'allgather_partitions': True, 'reduce_scatter': True, 'allgather_bucket_size': 200000000, 'reduce_bucket_size': 200000000, 'sub_group_size': 1000000000000}}, model=<Mock id='140346019654640'>, model_parameters=<filter object at 0x7fa4daac0e80>, optimizer=None, lr_scheduler=None, dist_init_required=False)

@amorehead
Copy link
Contributor Author

@Borda, let's see if this latest commit of mine fixes it.

@stale Stale
Copy link

stale bot commented Apr 16, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Apr 16, 2025
@stale stale bot removed the won't fix This will not be worked on label Apr 16, 2025
@amorehead
Copy link
Contributor Author

@Borda, may I ask for you to check the "Read the Docs" tests and why they are failing?

@Borda
Copy link
Member

Borda commented Jun 24, 2025 •
edited
Loading

may I ask for you to check the "Read the Docs" tests and why they are failing?

They can be flaky, so if all the other docs build pass you are essentially fine

@Borda Borda requested a review from lantiga June 27, 2025 14:51
@Borda Borda merged commit afa7d56 into Lightning-AI:master Jun 27, 2025
114 checks passed
@Borda Borda removed the waiting on author Waiting on user action, correction, or update label Jun 27, 2025
@amorehead
Copy link
Contributor Author

Thanks, @Borda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
docs Documentation related fabric lightning.fabric.Fabric strategy: deepspeed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amorehead @lantiga @Borda