[Merge] #14-booth detailpage UI 구현#19
Merged
Chaem03 merged 6 commits intoMar 1, 2025
Merged
Conversation
Chaem03
added
✨ Feature
sayyyho
approved these changes
Feb 28, 2025
sayyyho
left a comment
sayyyho
left a comment
Collaborator
There was a problem hiding this comment.
엄청 성장하는 채민님 보면서 자극 많이 받네요 ㅎㅎ 제가 적은 몇 가지만 수정해 봅시다!!
Comment on lines
+11
to
+28
| <S.LionInfoBox> | ||
| <S.TextBox> | ||
| <img src={calendar} /> | ||
| <S.TextInfo>모집 기간 | 2월 17일 (월) ~ 3월 9일 (일)</S.TextInfo> | ||
| </S.TextBox> | ||
| <S.TextBox> | ||
| <img src={pencil} /> | ||
| <S.TextInfo>신청 방법 | 구글 폼</S.TextInfo> | ||
| </S.TextBox> | ||
| <S.TextBox> | ||
| <a | ||
| href="https://www.instagram.com/likelion_dongguk" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| <img src={instaIcon} alt="Instagram" /> | ||
| </a> | ||
| <S.TextInfo>@likelion_dongguk</S.TextInfo> |
Collaborator
There was a problem hiding this comment.
저번에 말씀드린 거 처럼 constants에 children 값들 관리하면 좋을거 같아요!
| .writeText(pageUrl) | ||
| .then(() => alert("링크가 복사되었습니다!")) | ||
| .catch((err) => console.error("링크 복사 실패:", err)); | ||
| }; |
Collaborator
There was a problem hiding this comment.
이런 부분도요! 예를들어, 링크 복사 케이스는 COPY_SUCCESS_MESSAGE 등으로 쓸 수 있겠네요 ㅎㅎ
taejun0
approved these changes
Mar 1, 2025
Collaborator
There was a problem hiding this comment.
커스텀 훅으로 관리할 때, Data랑 Handler랑 분리해서 넘기면 보다 좋은 코드가 되더라고요 ! 나중에 디벨로 해봐요오 !!
| import useCustomNavigate from "../../hooks/useCustomNavigate"; | ||
| import MAP1 from "../../../public/images/map1.svg"; | ||
| import MAP2 from "../../../public/images/map2.svg"; | ||
| import mappin from "../../../public/images/mappin.svg"; |
Collaborator
There was a problem hiding this comment.
이미지를 하나하나 import 하는 거는 코드 줄을 많이 잡아먹으니까 상수화하는건 어떨까요오??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍀 ISSUE
🛠 Work Type
🔑 Work Description
-커스텀 훅으로 코드 리팩토링
📸 Screenshot
💻 Key Code
주요 코드 및 설명