Skip to content

Commit dceed59

Browse files
authored
Stop saying that we avoid a memory leak (#168)
Because @willow-ahrens fixed this leak in a non-breaking release of BenchmarkTools so it was apparently not unavoidable. (JuliaCI/BenchmarkTools.jl#385)
1 parent 3c86e3c commit dceed59

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

docs/src/explanations.md

+1-4
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,7 @@ A few reasons
4343
- Chairmarks runs its arguments as functions in the scope that the benchmark was invoked
4444
from, rather than `eval`ing them at global scope. This makes it possible to get
4545
significant performance speedups for fast benchmarks by putting the benchmarking itself
46-
into a function. It also avoids leaking memory on repeated invocations of a benchmark,
47-
which is unavoidable with BenchmarkTools.jl's design.
48-
([discourse](https://discourse.julialang.org/t/memory-leak-with-benchmarktools/31282),
49-
[github](https://github.com/JuliaCI/BenchmarkTools.jl/issues/339))
46+
into a function.
5047
- Because Charimarks does not use toplevel eval, it can run arbitrarily quickly, as limited
5148
by a user's noise tolerance. Consequently, the auto-tuning algorithm is tuned for low
5249
runtime budgets in addition to high budgets so its precision doesn't degrade too much at

0 commit comments

Comments
 (0)