Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managing newly created module dependencies on fly #3

Open
bartoszkubicki opened this issue Nov 2, 2021 · 1 comment
Open

Managing newly created module dependencies on fly #3

bartoszkubicki opened this issue Nov 2, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@bartoszkubicki
Copy link

That's enhancement I would find useful, but don't know the architecture of your library for now, so just posting an idea.

So, let's assume we generate certain types of templates, with an option of module creation on the fly. It would be nice to have dependencies sorted out in process. For example, generation of crontab, should be followed by adding dependency to Magento_Cron in module.xml and composer.json. However there are some issues I see:

  • it is possible only if we say 'yes' to question if we would like to have module generated - I assume we should get that question every time we generate something
  • it is a problem to resolve package version (for composer version) if we don't know for which magento version code is generated - it can be avoided by putting wildcard (*) on the other hand or we could specify our target magento version in some config file
  • matrix of dependencies vs template has to be stored in some config file, but I don't know if there are templates that can generate code dependant to different packages according to what we insert during survey in CLI
@michalbiarda
Copy link
Contributor

Thanks for the suggestion. It should be easy to add it for module.xml, but as you mentioned, might be tricky/impossible for composer.json. I'll think about it. Maybe it could be just added as "after generation" suggestion.

@michalbiarda michalbiarda added the enhancement New feature or request label Nov 2, 2021
marcin-dzdza-orba pushed a commit that referenced this issue Jun 7, 2023
Feature/ZZ12-125 rebranding

Approved-by: Marcin Dżdża
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants