Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile Version #1

Closed
root9191 opened this issue Jul 17, 2023 · 14 comments · May be fixed by #3
Closed

mobile Version #1

root9191 opened this issue Jul 17, 2023 · 14 comments · May be fixed by #3

Comments

@root9191
Copy link

Hello,
could you please optimize the Theme for mobile Version too?
If you select the Theme and look on your Smartphone, the Links are not centered and also the Background does not fit

@FuckingToasters
Copy link
Contributor

Hello, could you please optimize the Theme for mobile Version too? If you select the Theme and look on your Smartphone, the Links are not centered and also the Background does not fit

noticed that too. would like to see an mobile version.

@FuckingToasters
Copy link
Contributor

grafik

@JeanCFF
Copy link

JeanCFF commented Feb 21, 2024

Could someone who corrected this error share?

@matze19999
Copy link

I've tried, but I haven't found the error in the source code. I've compared it to other theme files but no luck

@talheim-it
Copy link

talheim-it commented Apr 5, 2024

@matze19999 @JeanCFF @FuckingToasters @root9191

Quick fix without merge request:
Go to themens/CloudyStorm/brands.css
The following line:
width: 500px;
height: 48;
Exchange with:
min-width: 250px;
height: auto;

The height is necessary otherwise it won't grow automatically when you have long descriptions of the buttons.

Works also on smartphones:
https://tree.tal.hm/@lostindesolation

@talheim-it
Copy link

@JulianPrieber I prepared a branch but cannot push the branch to the repository. Can you give me permissions to do so?

Then I can create a pull request for review.

@JulianPrieber
Copy link
Member

@JulianPrieber I prepared a branch but cannot push the branch to the repository. Can you give me permissions to do so?

Then I can create a pull request for review.

I'm sorry, but there aren't any public forks. Fork the repo, make the changes, open a pull request.

firefox_vzJxILH9M7

@talheim-it
Copy link

talheim-it commented Apr 5, 2024

@JulianPrieber never did before so thank for the hint, is completed.

I also linked the issue.

@FuckingToasters
Copy link
Contributor

FuckingToasters commented Jul 6, 2024

height: 48;

While this works, it makes the buttons small on desktop as well, i wantedd to keep them on dekstop the same so i've added a media query which handle this.

.button {
  position: relative;
  height: 23px;
  background-color: var(--accentColor);
  color: var(--textColor);
  border: solid var(--accentColor) 2px;
  border-radius: 10px;
  font-size: 1rem;
  text-align: center;
  display: block;
  margin-left: 10px;
  margin-right: 10px;
  margin-bottom: 10px;
  padding: 10px; /* 17px */
  text-decoration: none;
  height: auto;
  /* transition: all .25s cubic-bezier(.08, .59, .29, .99); */
  -webkit-tap-highlight-color: transparent;
}

/* Portrait mode */
@media (orientation: portrait) {
  .button {
    min-width: 250px;
  }
}

/* Landscape mode */
@media (orientation: landscape) {
  .button {
    min-width: 500px;
  }
}

@talheim-it
Copy link

@FuckingToasters great, can you create a pull request for it? Maybe that works for @JulianPrieber

@JulianPrieber
Copy link
Member

height: 48;

While this works, it makes the buttons small on desktop as well, i wantedd to keep them on dekstop the same so i've added a media query which handle this.

.button {
  position: relative;
  height: 23px;
  background-color: var(--accentColor);
  color: var(--textColor);
  border: solid var(--accentColor) 2px;
  border-radius: 10px;
  font-size: 1rem;
  text-align: center;
  display: block;
  margin-left: 10px;
  margin-right: 10px;
  margin-bottom: 10px;
  padding: 10px; /* 17px */
  text-decoration: none;
  height: auto;
  /* transition: all .25s cubic-bezier(.08, .59, .29, .99); */
  -webkit-tap-highlight-color: transparent;
}

/* Portrait mode */
@media (orientation: portrait) {
  .button {
    min-width: 250px;
  }
}

/* Landscape mode */
@media (orientation: landscape) {
  .button {
    min-width: 500px;
  }
}

I haven't been able to test this yet, but this looks promising 👍

@FuckingToasters
Copy link
Contributor

@FuckingToasters great, can you create a pull request for it? Maybe that works for @JulianPrieber

Sure thing, here you go: #4

@JulianPrieber
Copy link
Member

Love it

@JulianPrieber
Copy link
Member

Pushed to the updater system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants