fix: fix the simulated player using Player::getLangCode (#316)

zimuya4153 · web-flow · commit cdfcac5076fb · 2025-08-07T16:27:12.000+08:00
* fix: fix the simulated player using Player::getLangCode

* fix: add null check in getLangCode method
diff --git a/src/legacy/api/PlayerAPI.cpp b/src/legacy/api/PlayerAPI.cpp
@@ -1163,9 +1163,11 @@ Local<Value> PlayerClass::getRuntimeID() {
 
 Local<Value> PlayerClass::getLangCode() {
     try {
-        Json::Value& requestJson = get()->getConnectionRequest()->mRawToken->mDataInfo;
+        Player* player = get();
+        if (!player) return Local<Value>();
 
-        return String::newString(requestJson.get("LanguageCode", "unknown").asString("unknown"));
+        auto language = player->getLocaleCode();
+        return String::newString(language.empty() ? "unknown" : language);
     }
     CATCH("Fail in getLangCode!");
 }

Original file line number	Diff line number	Diff line change
`@@ -1163,9 +1163,11 @@ Local<Value> PlayerClass::getRuntimeID() {`
`1163`	`1163`
`1164`	`1164`	`Local<Value> PlayerClass::getLangCode() {`
`1165`	`1165`	`try {`
`1166`		`- Json::Value& requestJson = get()->getConnectionRequest()->mRawToken->mDataInfo;`
	`1166`	`+ Player* player = get();`
	`1167`	`+ if (!player) return Local<Value>();`
`1167`	`1168`
`1168`		`- return String::newString(requestJson.get("LanguageCode", "unknown").asString("unknown"));`
	`1169`	`+ auto language = player->getLocaleCode();`
	`1170`	`+ return String::newString(language.empty() ? "unknown" : language);`
`1169`	`1171`	`}`
`1170`	`1172`	`CATCH("Fail in getLangCode!");`
`1171`	`1173`	`}`