File tree 2 files changed +47
-1
lines changed
2 files changed +47
-1
lines changed Original file line number Diff line number Diff line change
1
+ # Contributing guide
2
+
3
+ 1 . create an issue to discuss the change
4
+ 2 . create a PR if change makes sense after the discussion
5
+ 3 . PR review + merge!
6
+
7
+ ## package manager
8
+
9
+ Use ` yarn ` , do not create package-lock.json from npm
10
+
11
+ ## code lint
12
+
13
+ The repo uses ** eslint** and ** prettier** to enforce some style and lint rules. Make sure that ` yarn lint ` runs successfully on your branch.
14
+
15
+ ## Local project setup
16
+
17
+ ### library setup
18
+
19
+ 1 . clone the repo (of your fork) in a separate folder
20
+ 2 . run ` yarn ` in the root directory
21
+ 3 . run ` yarn build ` in the root directory
22
+
23
+ (this should create a ` dist ` folder)
24
+
25
+ ### test app setup
26
+
27
+ 1 . open or create a new react native project (expo and RN CLI both work)
28
+ 2 . add a dependency in package.json like
29
+
30
+ ``` json
31
+ {
32
+ "dependencies" : {
33
+ "react-native-youtube-iframe" : " path/to/cloned/folder"
34
+ }
35
+ }
36
+ ```
37
+
38
+ 3 . run the app and use the iframe as stated in the docs
39
+
40
+ ### making changes
41
+
42
+ 1 . make a change in the cloned folder
43
+ 2 . run ` yarn build `
44
+ 3 . reload / refresh test app
Original file line number Diff line number Diff line change @@ -21,7 +21,9 @@ A wrapper of the Youtube IFrame player API build for react native.
21
21
22
22
## Contributing
23
23
24
- Pull requests are welcome. For major changes, please open an issue first to discuss what you would like to change.
24
+ Pull requests are welcome!
25
+
26
+ Read the [ contributing guide] ( ./CONTRIBUTING.md ) for project setup and other info
25
27
26
28
## License
27
29
You can’t perform that action at this time.
0 commit comments