mem: HG_MALLOC unit tests: start-up handshake, robust CI check

A test child now runs only after internal_fork() has returned in the
parent: a child that finished and exited within the parent's start-up wait
was reported as "failed to initialize". The CI step finds the allocator
check line unanchored, since other processes' log lines can share it.

Author: Lt-Flash

.github/workflows/unittests.yml

@@ -148,15 +148,16 @@ jobs:
         run: script -e unit_tests.log -c 'sh -x scripts/build/do_build.sh DEFS_EXTRA_OPTS="-DUNIT_TESTS -fPIE -fPIC"'
 
       # the same tests and the allocator suites with HG_MALLOC; the grep fails
-      # the step if HG_MALLOC was not actually the allocator under test
+      # the step if HG_MALLOC was not actually the allocator under test (not
+      # anchored: other processes' log lines can share a line with the TAP one)
       - name: Run tests with HG_MALLOC
         env:
           MAKE_TGT: 'test'
           UT_ALLOC: 'HG_MALLOC'
           UT_MEM: '-m 64:1024 -M 16:256'
         run: |
           script -e unit_tests_hg.log -c 'sh -x scripts/build/do_build.sh DEFS_EXTRA_OPTS="-DUNIT_TESTS -fPIE -fPIC"'
-          grep -q -E '^ok [0-9]+ - HG_MALLOC serves pkg and shm' unit_tests_hg.log
+          grep -E 'ok [0-9]+ - HG_MALLOC serves pkg and shm' unit_tests_hg.log | grep -q -v 'not ok'
 
       - name: Run tests with HG_MALLOC_DBG
         env:
@@ -165,7 +166,7 @@ jobs:
           UT_MEM: '-m 64:1024 -M 16:256'
         run: |
           script -e unit_tests_hg_dbg.log -c 'sh -x scripts/build/do_build.sh DEFS_EXTRA_OPTS="-DUNIT_TESTS -fPIE -fPIC"'
-          grep -q -E '^ok [0-9]+ - HG_MALLOC serves pkg and shm' unit_tests_hg_dbg.log
+          grep -E 'ok [0-9]+ - HG_MALLOC serves pkg and shm' unit_tests_hg_dbg.log | grep -q -v 'not ok'
 
       - name: Collect test logs
         uses: actions/upload-artifact@v7

mem/test/test_hg_malloc.c

@@ -51,6 +51,11 @@
 #define HGT_FAIL  2
 
 static volatile int *hgt_verdict;
+/* set by the parent once internal_fork() has returned: a child that ran
+ * and exited within the parent's start-up wait would otherwise be reported
+ * as "failed to initialize" (internal_fork() checks for an exited child
+ * before it re-reads the start-up result) */
+static volatile int *hgt_go;
 
 int hg_ut_selected(void)
 {
@@ -92,16 +97,21 @@ static int hgt_in_child(char *desc, int (*fn)(void *), void *arg)
 	int pid, waited;
 
 	*hgt_verdict = 0;
+	*hgt_go = 0;
 	pid = internal_fork(&ifp);
 	if (pid < 0) {
 		LM_ERR("failed to fork the '%s' child\n", desc);
 		return 0;
 	}
 
 	if (pid == 0) {
+		for (waited = 0; *hgt_go == 0 && waited < HGT_WAIT_US;
+		        waited += HGT_STEP_US)
+			usleep(HGT_STEP_US);
 		*hgt_verdict = fn(arg) == 0 ? HGT_PASS : HGT_FAIL;
 		exit(0);
 	}
+	*hgt_go = 1;
 
 	for (waited = 0; *hgt_verdict == 0 && waited < HGT_WAIT_US;
 	        waited += HGT_STEP_US)
@@ -448,8 +458,9 @@ void test_hg_malloc(void)
 		return;
 
 	hgt_verdict = shm_malloc(sizeof *hgt_verdict);
-	if (!hgt_verdict) {
-		ok(0, "shm verdict slot");
+	hgt_go = shm_malloc(sizeof *hgt_go);
+	if (!hgt_verdict || !hgt_go) {
+		ok(0, "shm verdict slots");
 		return;
 	}
 
@@ -466,6 +477,7 @@ void test_hg_malloc(void)
 	test_hg_double_free();
 
 	shm_free((void *)hgt_verdict);
+	shm_free((void *)hgt_go);
 }
 
 #endif /* HG_MALLOC */