Skip to content

Commit 8387cec

Browse files
lucaluca
authored andcommitted
Consolidate WiSE benchmark per PR ddmms#445 review
- Merge density / rdf / xray_sf into a single litfsi_h2o_21m benchmark under ml_peg/{calcs,analysis,app}/wise_electrolytes/litfsi_h2o_21m/. - Adopt the standard ml-peg patterns in the analysis and calc scripts: load_models(current_models) for model discovery, @build_table for the metrics table, and metrics.yml for thresholds/tooltips/weights. - Add a Janus recast of the LAMMPS+symmetrix Adastra production protocol in ml_peg/calcs/wise_electrolytes/md_reference/calc_md_reference.py (pytest-skipped reference; documents the exact MD parameters). - Add the docs page docs/source/user_guide/benchmarks/wise_electrolytes.rst (and toctree entry) and wire the app docs_url to it. - Update the parent wise_electrolytes.yml to a single benchmark weight.
1 parent ef5aecc commit 8387cec

20 files changed

Lines changed: 1798 additions & 2114 deletions

File tree

docs/source/user_guide/benchmarks/index.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,4 @@ Benchmarks
1717
tm_complexes
1818
conformers
1919
molecular_dynamics
20+
wise_electrolytes
Lines changed: 87 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,87 @@
1+
==================
2+
WiSE electrolytes
3+
==================
4+
5+
LiTFSI/H2O 21 m
6+
===============
7+
8+
Summary
9+
-------
10+
11+
Performance in predicting structural and thermodynamic properties of the 21 molal
12+
LiTFSI/H2O "water-in-salt" electrolyte (WiSE). The benchmark consolidates three
13+
experimental observables for the same chemistry: NPT equilibrium density, Li-O
14+
coordination from the radial distribution function, and the X-ray static
15+
structure factor S(q).
16+
17+
Two simulation cells are used: a small cell (16 LiTFSI + 42 H2O, 382 atoms) for
18+
the NPT density, and a large cubic cell (64 LiTFSI + 170 H2O, 1534 atoms,
19+
27.4938 A) for the NVT trajectories that feed the RDF and S(q).
20+
21+
Metrics
22+
-------
23+
24+
1. Density error
25+
26+
Absolute error in NPT density vs the experimental value
27+
(1.7126 g/cm3, Gilbert et al., *J. Chem. Eng. Data* 62, 2056 (2017)).
28+
The density is the average over the production NPT trajectory at
29+
298.15 K and 1 atm.
30+
31+
2. Li-O_water coordination number error
32+
33+
Absolute error in the Li-O_water coordination number, computed by
34+
integrating the Li-O_water radial distribution function up to the first
35+
minimum (R_cut = 2.83 A, from r2SCAN AIMD reference). Water oxygens are
36+
identified from the first frame as those bonded to a hydrogen
37+
(d_OH < 1.25 A). Reference value: 2.0 (Watanabe et al.,
38+
*J. Phys. Chem. B* 125, 7477 (2021), neutron diffraction with isotopic
39+
substitution at ~18.5 m).
40+
41+
3. Li-O_TFSI coordination number error
42+
43+
Same definition as above, restricted to TFSI oxygens (those bonded to a
44+
sulfur, d_OS < 1.75 A). Reference value: 2.0 (same source).
45+
46+
4. S(q) R-factor
47+
48+
R-factor between the computed and experimental X-ray structure factor,
49+
``sum(|S_exp - S_calc|) / sum(|S_exp|)``. S(q) is computed via dynasor
50+
in the Faber-Ziman convention with Cromer-Mann 4-Gaussian form factors
51+
(including hydrogen) and Savitzky-Golay smoothing
52+
(window = 27, order = 3, dq = 0.02 A^-1). Reference: SAXS data of
53+
Zhang et al., *J. Phys. Chem. B* 125, 4501 (2021).
54+
55+
Computational cost
56+
------------------
57+
58+
High: production trajectories require a GPU MD code (e.g. LAMMPS + symmetrix
59+
or Janus + MACE) and several hours per model on a single MI250X / A100 GPU.
60+
Re-extracting metrics from pre-computed trajectories is cheap (seconds per
61+
model).
62+
63+
Data availability
64+
-----------------
65+
66+
Input structures:
67+
68+
* p64_w170 cubic cell (1534 atoms, 27.4938 A) for NVT trajectories.
69+
* p16_w42 cell (382 atoms) for NPT density.
70+
71+
Production trajectories were generated with LAMMPS + symmetrix on Adastra
72+
(MI250X) using a MACE foundation model. The reference Janus recast of the
73+
same protocol (Min -> NVT 50 ps -> NPT 200 ps, dt = 0.5 fs, T = 298.15 K,
74+
P = 1.01325 bar, NH thermostat tau = 50 fs, NH barostat tau = 500 fs) lives
75+
in ``ml_peg/calcs/wise_electrolytes/md_reference/``.
76+
77+
Reference data:
78+
79+
* Density: Gilbert et al., *J. Chem. Eng. Data* 62, 2056 (2017),
80+
DOI: 10.1021/acs.jced.7b00135.
81+
* Li-O coordination numbers: Watanabe et al., *J. Phys. Chem. B* 125, 7477
82+
(2021), DOI: 10.1021/acs.jpcb.1c04693.
83+
* X-ray S(q): Zhang et al., *J. Phys. Chem. B* 125, 4501 (2021),
84+
DOI: 10.1021/acs.jpcb.1c02189.
85+
86+
Further details on the simulation protocol and MLIP assessment for this
87+
system: L. Brugnoli, arXiv:2603.22099 (2026).

ml_peg/analysis/wise_electrolytes/density/analyse_density.py

Lines changed: 0 additions & 298 deletions
This file was deleted.

0 commit comments

Comments
 (0)