Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Improve CORS headers settings granularity #387

Open
pvbergen opened this issue Dec 27, 2014 · 1 comment
Open

Suggestion: Improve CORS headers settings granularity #387

pvbergen opened this issue Dec 27, 2014 · 1 comment

Comments

@pvbergen
Copy link

Dear Luracast/Restler team,

I have two propositions concerning the CORS implementation in Restler RC5.

  • I have encountered an unexpected behavior when using Defaults::$crossOriginResourceSharing. Both Access-Control-Allow-Credentials and Access-Control-Max-Age are set to fixed values if CORS is enabled. I understand that this behavior might be useful to for people new to CORS. Nevertheless, allowing credentials or caching preflight responses for exactly a day might not be intented by the developer and he might prefer to override the default settings.
  • Secondly, it might be helpful to developers new to CORS to have a way to set additionally allowed headers (X type ones) using something array|string Defaults::$access-control-allow-headers. This allows to discourage the usage of non-prefixed custom headers too.

I know, both propositions are not of major importance, I just stumbled upon them when enabling CORS for my application and would like to hear your thoughts on them.

@Arul-
Copy link
Member

Arul- commented Jan 11, 2015

@pvbergen thanks for your suggestions, I will look at the possibilities and get back to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants