Skip to content

Commit 17562ac

Browse files
committed
Warn for using V2/third party manifests
1 parent 819161a commit 17562ac

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

cli/src/main/java/org/mcphackers/mcp/main/MainCLI.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,10 @@ public MainCLI(String[] args) {
5858
String version = null;
5959
Path versionPath = Paths.get(MCPPaths.VERSION);
6060
VersionParser versionParser = VersionParser.getInstance();
61+
if (!VersionParser.mappingsJson.equals(VersionParser.DEFAULT_JSON)) {
62+
warning("Using old or third party manifest URL: " + VersionParser.mappingsJson);
63+
warning("If this is not intentional, please update versionUrl in options.cfg to " + VersionParser.DEFAULT_JSON);
64+
}
6165
List<VersionData> versions = versionParser.getVersions();
6266
if (Files.exists(versionPath)) {
6367
try {

gui/src/main/java/org/mcphackers/mcp/main/MainGUI.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,10 @@ private void initialize() {
107107
e.printStackTrace();
108108
}
109109
}
110+
if (!VersionParser.mappingsJson.equals(VersionParser.DEFAULT_JSON)) {
111+
warning("Using old or third party manifest URL: " + VersionParser.mappingsJson);
112+
warning("If this is not intentional, please update versionUrl in options.cfg to " + VersionParser.DEFAULT_JSON);
113+
}
110114
frame = new MCPFrame(this);
111115
if (Util.getJavaVersion() > 8) {
112116
warning("JDK " + Util.getJavaVersion() + " is being used! Java 8 is recommended.");

src/main/java/org/mcphackers/mcp/tools/versions/VersionParser.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919

2020
public class VersionParser {
2121

22-
public static String mappingsJson = "https://mcphackers.org/versionsV3/versions.json";
22+
public static final String DEFAULT_JSON = "https://mcphackers.org/versionsV3/versions.json";
23+
public static String mappingsJson = DEFAULT_JSON;
2324
private static VersionParser INSTANCE;
2425

2526
private final List<VersionData> versions = new ArrayList<>();

0 commit comments

Comments
 (0)