add tdc uq into HLLC #883
Open
add tdc uq into HLLC #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmocz
added
the
release-blocker
warrickball
reviewed
Nov 10, 2025
Co-authored-by: Warrick Ball <[email protected]>
warrickball
reviewed
Nov 10, 2025
star/private/hydro_energy.f90
Outdated
Comment on lines
367
to
374
| if (k < s% nz) then | ||
| TDC_eturb_cell_start = 0.5d0*(pow2(s% mlt_vc_old(k)/sqrt_2_div_3) + & | ||
| pow2(s% mlt_vc_old(k+1)/sqrt_2_div_3)) | ||
| TDC_eturb_cell = 0.5d0*(pow2(s% mlt_vc_ad(k)/sqrt_2_div_3) + & | ||
| pow2(shift_p1(s% mlt_vc_ad(k+1))/sqrt_2_div_3)) | ||
| else ! center cell averaged with 0 for inner face | ||
| TDC_eturb_cell_start = 0.5d0*pow2(s% mlt_vc_old(k)/sqrt_2_div_3) | ||
| TDC_eturb_cell = 0.5d0*pow2(s% mlt_vc(k)/sqrt_2_div_3) |
Contributor
There was a problem hiding this comment.
I feel like there's some simple factorisation of the constants available here. We've got (√(3/2))² from the pow2 expressions and ½ out front, so is this not the same as
Suggested change
| if (k < s% nz) then | |
| TDC_eturb_cell_start = 0.5d0*(pow2(s% mlt_vc_old(k)/sqrt_2_div_3) + & | |
| pow2(s% mlt_vc_old(k+1)/sqrt_2_div_3)) | |
| TDC_eturb_cell = 0.5d0*(pow2(s% mlt_vc_ad(k)/sqrt_2_div_3) + & | |
| pow2(shift_p1(s% mlt_vc_ad(k+1))/sqrt_2_div_3)) | |
| else ! center cell averaged with 0 for inner face | |
| TDC_eturb_cell_start = 0.5d0*pow2(s% mlt_vc_old(k)/sqrt_2_div_3) | |
| TDC_eturb_cell = 0.5d0*pow2(s% mlt_vc(k)/sqrt_2_div_3) | |
| if (k < s% nz) then | |
| TDC_eturb_cell_start = 0.75d0*(pow2(s% mlt_vc_old(k)) + & | |
| pow2(s% mlt_vc_old(k+1))) | |
| TDC_eturb_cell = 0.75d0*(pow2(s% mlt_vc_ad(k)) + & | |
| pow2(shift_p1(s% mlt_vc_ad(k+1)))) | |
| else ! center cell averaged with 0 for inner face | |
| TDC_eturb_cell_start = 0.75d0*pow2(s% mlt_vc_old(k)) | |
| TDC_eturb_cell = 0.75d0*pow2(s% mlt_vc(k)) |
Member
Author
There was a problem hiding this comment.
Ahh yes, I didn't even consider reducing this. Good catch. (3/2) * (1/2) -> 3/4
warrickball
reviewed
Nov 10, 2025
| integer :: k, op_err | ||
| include 'formats' | ||
| ierr = 0 | ||
| op_err = 0 |
Contributor
There was a problem hiding this comment.
Do we actually use op_err? It looks like both it and ierr and initialised as zero, then ierr is changed to match op_err whenever the latter is non-zero. But that seems the same as just using ierr instead of op_err.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly includes tdc Uq into HLLC as a non-HSE source in the du/dt eqn, and fixes other bugs. Needs further polish before merge.