Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with variable initial loss for different zref #61

Open
alizma opened this issue Feb 24, 2024 · 1 comment
Open

Fix issue with variable initial loss for different zref #61

alizma opened this issue Feb 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@alizma
Copy link
Member

alizma commented Feb 24, 2024

For the pure Mann fit, the initial loss changes when zref changes, which shouldn't happen. To summarize the discussion of this issue thus far: this is a scaling issue and happens either because the data from DataGanerator are improperly scaled, or because the output of theOnePointSpectra class immediately after initialization are incorrectly scaled. Refer to the discussion in #60 for more details.

@alizma alizma added the bug Something isn't working label Feb 24, 2024
@alizma
Copy link
Member Author

alizma commented Mar 1, 2024

This issue is being contained to this branch with the debug trace from our earlier attempt today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant