Upgrading raw loops to use std::accumulate and other STL algorithms

[cvf-bcn-gituser]

Hello,

I was checking out the following raw loop in the CPP code modules in "src\algorithms\rhythm\superfluxnovelty"

for (int j = 0;j<nBands;j++) {
  cur_diff= bands[i][j]-maxsBuffer[j];
  if (cur_diff > 0.0) {
    diffs +=cur_diff ;
  }
}

With the STL lib algorithms"accumulate"
https://en.cppreference.com/w/cpp/algorithm/accumulate
we could replace this with one line, using a "capture by reference" to get something like this:

diffs = accumulate(begin[bands[i]),end(bands[i]), 0, [&] (int diffs,int j){ if (bands[i][j]-maxsBuffer[j]>0) return bands[i][j]-maxsBuffer[j]+diffs; return diffs;}

There are good examples of the use of the STL algorithm "find_if" in crest.cpp and entropy.cpp and perhaps it could be extended to other nested functions that are called regularly.
I was wondering if anyone has optimized any parts of the code in this way with better performance results?

[cvf-bcn-gituser]

I would just like to add that I think that the above suggested change would probably make it less readable and therefore extendible.

In general, I would like to extend the code painlessly. For example, in the spectral/flux.cpp module I would like to add reverse-coding (SFrc) and reverse rectification (SFrr) for an additional option to detect offsets that would not involve just adding more "else if" statements.

But to do this, would need the use of a type of Factory pattern.