Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Incompatible with DnD5e V4 #489

Open
maxobremer opened this issue Sep 11, 2024 · 2 comments
Open

[BUG] Incompatible with DnD5e V4 #489

maxobremer opened this issue Sep 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@maxobremer
Copy link

Description
The coming version of changed quit a bit and is not compatible with the current version of RSR. Some errors of note:

  • Using an item/activity: The dnd5e.preUseItem hook has been deprecated and replaced with `dnd5e.preUseActivity'
  • Also from using an item (spell, cantrip, weapon or sneak attack): Uncaught (in promise) TypeError: usageConfig.consume?.resources.includes is not a function
  • Damage roll: The dnd5e.preRollDamage hook has been deprecated and replaced with dnd5e.preRollDamageV2
  • Saving throw from a chat card: You are accessing the global "Die" which is now namespaced under foundry.dice.terms.Die
    Deprecated since Version 12
  • Using a loot item (which cant have activities, example being a bedroll): Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'size')

Rolling saves, skills and ability checks from the character sheet itself seems completely fine. Rolling anything from an item seems to not work
Also small note, initiative rolls seem to roll as core foundry rolls, their chat cards don't use the stylising of RSR.

Steps to Reproduce

  1. Install the prerelease version 4.0.0 of dnd5e
  2. Enable RSR
  3. Try to roll some attacks with a starter hero
  4. See error

Versions

  • Module: [3.2.0]
  • dnd5e: [4.0.0]
  • Foundry: [12.331 (node version)]

Other Modules
None

@maxobremer maxobremer added the bug Something isn't working label Sep 11, 2024
@maxobremer
Copy link
Author

I think no one was expecting RSR to work with v4 from the get go, but this issue is there to keep track of it

@crash1115
Copy link

crash1115 commented Sep 14, 2024

One thing that might be worth considering during this update is allowing users to select which individual types of items or activities quick roll. There were a couple changes and improvements to certain roll dialogs that users might want to have access to, while still fast forwarding other roll types. Off the top of my head:

  • A selector for 1-handed/2-handed (for versatile), thrown, and offhand attacks appears in the attack dialog
  • A selector for ammunition appears in the attack dialog
  • The damage dialog has a situational bonus field for each type of damage now

Sample use case:
Someone rocking a versatile weapon might want attacks to roll normally so they can get the 1h/2h selector in the attack dialog, but have damage, spells and utility activities fast forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants