chore: remove react dependency and monitoring state endpoint. (#93)

Co-authored-by: Thibaut FARCIN <[email protected]>

Author: M0nkeySan

.env.development

@@ -3,7 +3,6 @@ EMAIL_DOMAINS=my-domain.com,ext.my-domain.com
 GITLAB_SECRET=GITLAB_SECRET
 GITLAB_TOKEN=GITLAB_TOKEN
 GITLAB_URL=https://my-git.domain.com
-MONITORING_ENABLED=true
 NODE_ENV=development
 POSTGRES_DATABASE_NAME=homer
 POSTGRES_HOST=localhost

.env.test

@@ -4,7 +4,6 @@ EMAIL_DOMAINS=my-domain.com,ext.my-domain.com
 GITLAB_SECRET=GITLAB_SECRET
 GITLAB_TOKEN=GITLAB_TOKEN
 GITLAB_URL=https://my-git.domain.com
-MONITORING_ENABLED=true
 NODE_ENV=test
 POSTGRES_DATABASE_NAME=homer
 POSTGRES_HOST=localhost

README.md

@@ -253,14 +253,6 @@ the following variables:
 - `POSTGRES_PORT`: port where the database listens.
 - `POSTGRES_USER`: username used when connecting to the database.
 
-For debug purposes:
-
-- `MONITORING_ENABLED`: expose monitoring at `/api/monitoring/state`. Defaults to `true`.
-
-  🔒 Monitoring is exposing sensitive data. Please be aware of it if you expose it publicly (see [this issue](https://github.com/ManoManoTech/homer/issues/89)).
-
-  ⚠️ We will move this value to `false` by default in a new breaking change version soon.
-
 ### 5. Install and run
 
 ```bash

package.json

@@ -32,9 +32,6 @@
     "pg": "8.9.0",
     "pg-hstore": "2.3.4",
     "pino": "8.10.0",
-    "prismjs": "1.29.0",
-    "react": "18.2.0",
-    "react-dom": "18.2.0",
     "sequelize": "6.28.0",
     "slackify-markdown": "4.3.1",
     "source-map-support": "0.5.21",
@@ -47,9 +44,6 @@
     "@types/node": "18.13.0",
     "@types/node-fetch": "2.6.2",
     "@types/pg": "8.6.6",
-    "@types/prismjs": "1.26.0",
-    "@types/react": "18.0.27",
-    "@types/react-dom": "18.0.10",
     "@types/signale": "1.4.4",
     "@typescript-eslint/eslint-plugin": "5.62.0",
     "@typescript-eslint/parser": "5.51.0",

src/core/requestHandlers/stateRequestHandler/Highlight.tsx

@@ -140,12 +140,6 @@ export async function getProjectReleases(
   ).map(formatRelease);
 }
 
-export async function getProjects(): Promise<DataProject[]> {
-  return (await Project.findAll({ order: [['createdAt', 'DESC']] })).map(
-    toJSON
-  );
-}
-
 export async function getProjectsByChannelId(
   channelId: string
 ): Promise<DataProject[]> {
@@ -163,10 +157,6 @@ export async function getReleases(
   ).map(formatRelease);
 }
 
-export async function getReviews(): Promise<DataReview[]> {
-  return (await Review.findAll({ order: [['createdAt', 'DESC']] })).map(toJSON);
-}
-
 export async function getReviewsByChannelId(
   channelId: string
 ): Promise<DataReview[]> {

src/core/requestHandlers/stateRequestHandler/State.tsx

@@ -4,10 +4,8 @@ import helmet from 'helmet';
 import { errorMiddleware } from '@/core/middlewares/errorMiddleware';
 import { securityMiddleware } from '@/core/middlewares/securityMiddleware';
 import { healthCheckRequestHandler } from '@/core/requestHandlers/healthCheckRequestHandler';
-import { stateRequestHandler } from '@/core/requestHandlers/stateRequestHandler/stateRequestHandler';
 import { connectToDatabase } from '@/core/services/data';
 import { logger } from '@/core/services/logger';
-import { catchAsyncRouteErrors } from '@/core/utils/catchAsyncRouteErrors';
 import { waitForNonReadyReleases } from '@/release/commands/create/utils/waitForNonReadyReleases';
 import { REQUEST_BODY_SIZE_LIMIT } from './constants';
 import { getEnvVariable } from './core/utils/getEnvVariable';
@@ -33,20 +31,6 @@ export async function start(): Promise<() => Promise<void>> {
     app.use(express.urlencoded({ extended: true, verify }));
     app.get('/api/monitoring/healthcheck', healthCheckRequestHandler);
 
-    let enableMonitoring = true;
-    try {
-      enableMonitoring = getEnvVariable('MONITORING_ENABLED') === 'true';
-    } catch (error) {
-      logger.warn(
-        `Monitoring is enabled by default. Not defining MONITORING_ENABLED is deprecated and will throw an error in 1.0.0`
-      );
-    }
-    if (enableMonitoring) {
-      app.get(
-        '/api/monitoring/state',
-        catchAsyncRouteErrors(stateRequestHandler)
-      );
-    }
     app.use(securityMiddleware);
     app.use(getEnvVariable('API_BASE_PATH'), router);
     app.use(errorMiddleware);