Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The abnormal PAUSE behavior #27377

Open
1 task
dupaser opened this issue Aug 29, 2024 · 5 comments
Open
1 task

[BUG] The abnormal PAUSE behavior #27377

dupaser opened this issue Aug 29, 2024 · 5 comments

Comments

@dupaser
Copy link

dupaser commented Aug 29, 2024

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

I am using a BTT SKR PRO V1.2 and a MKS H43 DWIN display.
At the moment I have version 2.0.9.5. I have tried using different versions of Marlin, but there is a problem everywhere (somewhere the movement is worked out incorrectly and sometimes the Watchdog is triggered).

When I activate #define DGUS_LCD_UI_MKS and comment //#define ADVANCED_PAUSE_FEATURE :
If it is a pause with the M25 command, which is located on the USB Flash, then parking occurs correctly.
But if I press the pause button on the display, then a double movement is performed (At the beginning, it goes to the pause point, but then returns to the print area).
(i comment out a line queue.exhaust(); in void MKS_pause_print_move(), otherwise, the watchdog is triggered and the board is rebooted).

With St-Link debugging, it is visible that the few next commands are written to the "destination" variable after the coordinates of park position, which is not present when pausing from a USB media.

Bug Timeline

No response

Expected behavior

Stopping the nozzle at the park position

Actual behavior

Stopping the nozzle at the park position and move to next coordinate

Steps to Reproduce

#define MOTHERBOARD BOARD_BTT_SKR_PRO_V1_2
#define DGUS_LCD_UI_MKS
#define USE_MKS_GREEN_UI

Version of Marlin Firmware

2.0.9.5

Printer model

No response

Electronics

MOTHERBOARD BOARD_BTT_SKR_PRO_V1_2

LCD/Controller

DGUS_LCD_UI_MKS

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

@dupaser dupaser closed this as completed Aug 29, 2024
@dupaser dupaser changed the title [BUG] The abnormal behavior "PARK_HEAD_ON_PAUSE" [BUG] The abnormal PAUSE behavior Aug 29, 2024
@dupaser
Copy link
Author

dupaser commented Aug 29, 2024

Update info

@dupaser dupaser reopened this Aug 29, 2024
@thisiskeithb
Copy link
Member

Please attach your bugfix-2.1.x configs.

@dupaser
Copy link
Author

dupaser commented Aug 29, 2024

Good afternoon, thank you for your quick response. I downloaded your archive and configured it according to my parameters. There were issues with building the firmware in DGUS. Everywhere I made changes, I left a comment with the original value and an identifier "332211" so you could easily find them. The main problem was with the name DGUS_SCREEN_MAIN, which I replaced with DGUSLCD_SCREEN_MAIN, and DGUS_SCREEN_STATUS, which I replaced with DGUSLCD_SCREEN_STATUS. As a result, I ran my parameters and observed the same issues I described earlier. If the line is not commented out, the board restarts.

"Changes are only in /mks and in configuration files."

https://github.com/dupaser/Marlin-bugfix-2.1.x-1-

@dupaser
Copy link
Author

dupaser commented Aug 30, 2024

This is solution in void MKS_pause_print_move()

if (nozzle_park_mks.print_pause_start_flag)
{ queue.exhaust(); }

@narno2202
Copy link
Contributor

@dupaser , I'm refactoring the MKS_H43 code when i saw your comment. I've already fixed some bugs and changed some wordings. Could you have a look?
https://github.com/narno2202/Marlin/tree/MKS_H43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants