New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Visibility of annotated classes can not be internal #4

Open

oSumAtrIX opened this issue Dec 5, 2023 · 3 comments

oSumAtrIX commented Dec 5, 2023

Issue

When you annotate an enum class that is internal, you get this issue:

Solution

Use the annotated classes visibility modifier

Possibly related line of code

https://github.com/MateriiApps/enumutil-kt/blob/master/enumutil-ksp/src/main/kotlin/com/github/materiiapps/enumutil/ksp/FromValueVisitor.kt#L126-L126

Member

rushiiMachine commented Dec 5, 2023

can you show your full DialogKind enum

Author

oSumAtrIX commented Dec 6, 2023

You should be able to reproduce with this line: https://github.com/ReVanced/revanced-manager/blob/49c45b39b4ea79cd477675ad00e09dca0fb4956a/app/src/main/java/app/revanced/manager/ui/component/InstallerDialog.kt#L85

Member

rushiiMachine commented Dec 6, 2023

Use the annotated classes visibility modifier

it does; what's interesting is why it's null for some reason
i'll have to dig a bit ig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment