Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcm retries to infinity and beyond (*11 days) #31

Open
julianhille opened this issue Nov 8, 2019 · 1 comment · May be fixed by #32
Open

gcm retries to infinity and beyond (*11 days) #31

julianhille opened this issue Nov 8, 2019 · 1 comment · May be fixed by #32

Comments

@julianhille
Copy link
Contributor

The gcm module uses the local request lib from utils/request.js
This lib auto retries the connection and has no limitation on retries.

Example: If there is some snake oil in the network or on the host machine like an "endpoint protection" which injects ssl certs this will be retried with something like "Error: SSL Cert self signed certificate in certificate chain" but will NEVER raise any exception or give up retrying.

I guess this would finally fail after round about 10-11 days with Maximum call stack size exceeded (max stack size default in node 984, 15 seconds wait time ... you do the math).

@MatthieuLemoine
Copy link
Owner

You're right. This module could use a clever retry strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants