Skip to content

profsea-climate Clear distinction between AR6 and AR5 methods #38

@hmkhatri

Description

Currently, both AR5 and AR6 methods are executed for several components, e.g. icesheets, land storage. It is not clear which ones are used for the final projections, unless one goes through the source code.

I suggest pass a string (AR5 or AR6) as an input in Global class, so a user is aware how the components are computed. Then, we can use if-else in the following code to assign components accordingly.

def get_components(self) -> dict:
"""Get all GMSLR components as a dictionary."""
components_dict = {
'expansion': self.expansion,
'glacier': self.glacier,
'greenland': self.greenland_ar6,
'greendyn': self.greendyn,
'greensmb': self.greensmb,
'antsmb': self.antsmb,
'antdyn': self.antdyn,
'antnet': self.antnet,
'landwater': self.landwater,
'gmslr': self.gmslr
}

Greg Munday (@gregrmunday) What are your thoughts on this?

Also, should it be landwater_ar6 in the following

self.landwater = self.landwater[random_idx][None, :]

Metadata

Metadata

Assignees

No one assigned
    No fields configured for Feature.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions