fix test case for vault not updated

Author: mikesposito

packages/keyring-controller/jest.config.js

@@ -17,10 +17,10 @@ module.exports = merge(baseConfig, {
   // An object that configures minimum threshold enforcement for coverage results
   coverageThreshold: {
     global: {
-      branches: 93.1,
+      branches: 94.25,
       functions: 100,
-      lines: 98.64,
-      statements: 98.65,
+      lines: 98.79,
+      statements: 98.8,
     },
   },
 

packages/keyring-controller/src/KeyringController.test.ts

@@ -3066,33 +3066,6 @@ describe('KeyringController', () => {
           );
         });
 
-        !cacheEncryptionKey &&
-          it('should not upgrade the vault encryption if the generic encryptor has the same parameters', async () => {
-            await withController(
-              {
-                skipVaultCreation: true,
-                cacheEncryptionKey,
-                state: { vault: 'my vault' },
-              },
-              async ({ controller, encryptor }) => {
-                jest.spyOn(encryptor, 'isVaultUpdated').mockReturnValue(true);
-                const encryptSpy = jest.spyOn(encryptor, 'encrypt');
-                jest.spyOn(encryptor, 'decrypt').mockResolvedValueOnce([
-                  {
-                    type: KeyringTypes.hd,
-                    data: {
-                      accounts: ['0x123'],
-                    },
-                  },
-                ]);
-
-                await controller.submitPassword(password);
-
-                expect(encryptSpy).toHaveBeenCalledTimes(1);
-              },
-            );
-          });
-
         !cacheEncryptionKey &&
           it('should throw error if password is of wrong type', async () => {
             await withController(