From d3dcef784727bf3c10ea7c3f2d3d76fae5f51834 Mon Sep 17 00:00:00 2001 From: Micaela Estabillo Date: Fri, 7 Mar 2025 13:33:16 -0800 Subject: [PATCH] fix: lint and unit test --- shared/types/bridge.ts | 2 +- ui/ducks/bridge/bridge.test.ts | 7 ++++++- ui/hooks/bridge/useTokensWithFiltering.ts | 7 ++----- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/shared/types/bridge.ts b/shared/types/bridge.ts index 4088b6695274..0d818da80974 100644 --- a/shared/types/bridge.ts +++ b/shared/types/bridge.ts @@ -54,7 +54,7 @@ export type BridgeToken = { balance: string; // raw balance string: string | undefined; // normalized balance as a stringified number tokenFiatAmount?: number | null; -} | null; +}; // Types copied from Metabridge API export enum BridgeFlag { diff --git a/ui/ducks/bridge/bridge.test.ts b/ui/ducks/bridge/bridge.test.ts index 5dc1a60f2710..c9005fbaa703 100644 --- a/ui/ducks/bridge/bridge.test.ts +++ b/ui/ducks/bridge/bridge.test.ts @@ -101,7 +101,12 @@ describe('Ducks - Bridge', () => { expect(actions[0].type).toStrictEqual('bridge/setToToken'); const newState = bridgeReducer(state, actions[0]); expect(newState.toToken).toStrictEqual( - expect.objectContaining({ ...actionPayload, chainId: 'eip155:10' }), + expect.objectContaining({ + ...actionPayload, + balance: '0', + chainId: '0xa', + string: '0', + }), ); }); }); diff --git a/ui/hooks/bridge/useTokensWithFiltering.ts b/ui/hooks/bridge/useTokensWithFiltering.ts index 724fae673442..854c7dfb093f 100644 --- a/ui/hooks/bridge/useTokensWithFiltering.ts +++ b/ui/hooks/bridge/useTokensWithFiltering.ts @@ -36,6 +36,7 @@ import { type BridgeAppState, getTopAssetsFromFeatureFlags, } from '../../ducks/bridge/selectors'; +import { type BridgeToken } from '../../../shared/types/bridge'; type FilterPredicate = ( symbol: string, @@ -59,11 +60,7 @@ type FilterPredicate = ( */ export const useTokensWithFiltering = ( chainId?: ChainId | Hex | CaipChainId, - tokenToExclude?: null | { - symbol: string; - address?: string; - chainId?: string; - }, + tokenToExclude?: null | Pick, ) => { const allDetectedTokens: Record = useSelector( getAllDetectedTokensForSelectedAddress,