[Sentry] Error: Account name already exists

[sentry-io]

Sentry Issue: METAMASK-XBQ5

Error: Account name already exists
  at exports.defaultsetAccountLabel (app/scripts/controllers/preferences.js:441:26)
  at MetamaskController.unlockHardwareWalletAccount (app/scripts/metamask-controller.js:4218:32)
  at async i.<anonymous> (app/scripts/lib/createMetaRPCHandler.js:23:7)
...
(1 additional frame(s) were not displayed)

[Akaryatrh]

I was able to replicate. I'll make the demonstration with a Ledger account but it could be any other hardware wallet account importing action.

• remove all existing ledger accounts
• add new MM account and name it "Ledger 1"
• add new hardware account, select Ledger and and select first account
• See that error "Account name already exists" is displayed above account list
• See that we have an uncaught error "Account name already exists" on console.

(Sorry for the 10s delay around 00:30s, i was unlocking the Ledger device)

BTW, I can not replicate the issue on develop branch, so bug might have been fixed with a recent commit.

Private Zenhub Video

[vivek-consensys]

@Akaryatrh I am able to reproduce using the latest develop build.

[Akaryatrh]

New update: finally issue can be reproduced when creating a build, but not on dev mode. I'm investigating where error is not caught then.

EDIT: I also found out that, despite the error message, account was anyway imported. So user ends up with 2 "Ledger 1" accounts on its accounts list (fortunately, real ledger account gets a "ledger" badge so we can identify it).

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

[angelcheung22]

Reference ticket: 'Multiple devices not supported yet, please forget your previous device first before adding a new one'
https://app.zenhub.com/workspaces/cet-metamask-hardware-wallets-6566ee6aedc46007d5a260bb/issues/gh/metamask/metamask-extension/30519

[gantunesr]

Reference ticket: 'Multiple devices not supported yet, please forget your previous device first before adding a new one' https://app.zenhub.com/workspaces/cet-metamask-hardware-wallets-6566ee6aedc46007d5a260bb/issues/gh/metamask/metamask-extension/30519

Hi @angelcheung22, is this ticket you linked a variation of this bug or a new one? I can't open the link so it is unclear to me. If this bug about account naming has its root on the accounts-controller then it should be delegate to my team to solve

[Akaryatrh]

@gantunesr

• issue originaly comes from preference controller as account controller called function throws an error that is not caught. But this function is now deprecated and I actually removed it on my PR.
• indeed account naming happens inside account-controller, but it's also done on metamask-controller side (because we append hdpath description to the account name, and i don't think account controller has this info). Having both sides naming the accounts actually creates race condition issues (that I encountered in my PR).
• About the above linked ticket from zenhub (here's the GH link), It has been added because the same"Account name already exists" has been seen during testing.

I think it would be great to involve account team in the resolution of this ticket 👍