[Bug]: smartTransaction:showSmartTransactionStatusPage' already pending for origin chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn. Please wait.

[rkalis]

Describe the bug

This bug happens when "smart transactions" are turned on, and multiple transactions are submitted in quick succession. The first one to be submitted will use the "smart transactions" setup as expected. But the second transaction will stall, and ultimately return an RPC error:

smartTransaction:showSmartTransactionStatusPage' already pending for origin chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn. Please wait.

Seemingly, MM does queue up this transaction as it does end up getting confirmed later on, but the application that initiated the transactions will not receive any notice of this. This causes the application that initiated the transaction to report a failed transaction

Expected behavior

I'd expect that MM returns either a failure when the transaction could not be submitted or a success response when it can be. Rather than MM returning a failure response even though the transaction does end up getting submitted.

Screenshots/Recordings

Steps to reproduce

This issue can be reproduced on any website that submits multiple transactions, such as Revoke.cash's batch revoke functionality.

Prerequisites:

• Enable smart transactions in MM
• Have multiple token approvals

Steps to reproduce:

1. Go to Revoke.cash and connect your MM wallet
2. Select multiple token approvals to revoke and click "Revoke selected"
3. Select "No tip" and click "Revoke"
4. Accept the transactions in your MM wallet

Error messages or log output

No response

Detection stage

In production (default)

Version

12.5.1

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

[DanielTech21]

Hi @rkalis

Thank you for bringing this to our attention.

Our team will look into this.

Thank you!

[rkalis]

Any updates?

[rkalis]

I've also seen different issues recently, where some of the smart transactions just stall indefinitely and end up in a sort of limbo where the website has submitted the transaction but MM doesn't pop up for that specific transaction. The steps to reproduce this are the same as mentioned above and I've only seen them happen when trying to send multiple transactions in quick succession.

[forest-diggs-consensys]

Hi @rkalis - we have a short-term mitigation for this in 12.9.2 to avoid this case, preventing a new Smart Transaction from being submitted while one is in progress. I know this isn't ideal, and in January we'll be rolling out another improvement to support having multiple Smart Transactions submitted sequentially without running into this issue.

[lokesh-systango]

Getting the same issue in the latest version 12.11.0

Encounter this problem when executing multiple transactions sequentially—specifically when a second transaction is triggered immediately after the successful completion of the first transaction.

In this version, the first MetaMask pop-up functions correctly, but the second pop-up may indicate a failure, even though the transaction will eventually be confirmed on the blockchain.

My observation is that if you do not close the extension—something you might do after the first transaction by clicking the "Close Extension" button—the next transaction loads within the same pop-up. This causes it to use outdated values from the initial load, leading to a simulated failure. However, the transaction does not fail in reality, as the previous transaction on the blockchain has already been completed.

FYI, this issue does not occur if you close the extension after the first transaction and allow a new pop-up to open for the next transaction.

[johnnyshankman]

Would love to see this get over the line, seen a few users report this and it causes quite the headache for front end UX to get an error on a successful transaction. Lots of people accidentally doubling up on transactions etc.

[wwhchung]

Note that this may not be isolated to submitting multiple transactions. We are getting reports of this same issue with people using Metamask in combination with Trezor Midel T when only one transaction is submitted.