[Bug]: Infinity crashing, can't start it

[Laurentiu-Andronache]

Describe the bug

I click on it, it "loads" for 10 seconds, then it crashes. First it did it in one Chrome profile, and I stopped using it there. Then it did the same in another profile.

Expected behavior

Not this.

Screenshots/Recordings

Steps to reproduce

I can replicate the issue by just doing 20-30 transactions in a row with a lot of calldata. Afterwads, MetaMask doesn't open anymore.

How to clear the transaction data from the Metamask local database without losing the wallets?

Error messages or log output

"""md
SCRIPTS IMPORT COMPLETE in Seconds: 1.8
sentry-install.js:1 MetaMask initialization complete.
sentry-install.js:1 RPC (https://metamask.github.io): metamask_getProviderState -> success
sentry-install.js:1 RPC (https://metamask.github.io): metamask_sendDomainMetadata -> success

sentry-install.js:1 **(Error#1)**
(anonymous) @ sentry-install.js:1
(anonymous) @ sentry-install.js:3
error @ runtime-lavamoat.js:7134
(anonymous) @ common-0.js:1
(anonymous) @ common-8.js:1
(anonymous) @ sentry-install.js:1
(anonymous) @ common-8.js:1
(anonymous) @ common-8.js:1
(anonymous) @ sentry-install.js:1
(anonymous) @ common-8.js:1
d @ common-8.js:1
(anonymous) @ common-5.js:13
y @ common-5.js:13
m @ common-5.js:13
(anonymous) @ sentry-install.js:1
(anonymous) @ common-7.js:1
h @ common-7.js:1
(anonymous) @ sentry-install.js:1
i @ sentry-install.js:3
**setTimeout**
(anonymous) @ sentry-install.js:1
(anonymous) @ sentry-install.js:3
(anonymous) @ runtime-lavamoat.js:12866
(anonymous) @ runtime-lavamoat.js:12866
(anonymous) @ runtime-lavamoat.js:12866
u @ common-7.js:1
(anonymous) @ common-7.js:1
C @ common-8.js:1
I @ common-8.js:1
S @ common-8.js:1
(anonymous) @ common-8.js:1
_write @ common-1.js:1
S @ common-8.js:1
(anonymous) @ common-8.js:1
(anonymous) @ common-8.js:1
l @ common-5.js:13
(anonymous) @ common-5.js:13
H @ common-5.js:13
U @ common-5.js:13
F.push @ common-5.js:13
_onMessage @ common-5.js:13
(anonymous) @ common-5.js:13Understand this errorAI

sentry-install.js:1 **Error#1: PortDuplexStream - disconnected**
(anonymous) @ sentry-install.js:1
(anonymous) @ sentry-install.js:3
logError @ runtime-lavamoat.js:7087
logSubErrors @ runtime-lavamoat.js:7030
error @ runtime-lavamoat.js:7136
(anonymous) @ common-0.js:1
(anonymous) @ common-8.js:1
(anonymous) @ sentry-install.js:1
(anonymous) @ common-8.js:1
(anonymous) @ common-8.js:1
(anonymous) @ sentry-install.js:1
(anonymous) @ common-8.js:1
d @ common-8.js:1
(anonymous) @ common-5.js:13
y @ common-5.js:13
m @ common-5.js:13
(anonymous) @ sentry-install.js:1
(anonymous) @ common-7.js:1
h @ common-7.js:1
(anonymous) @ sentry-install.js:1
i @ sentry-install.js:3
setTimeout
(anonymous) @ sentry-install.js:1
(anonymous) @ sentry-install.js:3
(anonymous) @ runtime-lavamoat.js:12866
(anonymous) @ runtime-lavamoat.js:12866
(anonymous) @ runtime-lavamoat.js:12866
u @ common-7.js:1
(anonymous) @ common-7.js:1
C @ common-8.js:1
I @ common-8.js:1
S @ common-8.js:1
(anonymous) @ common-8.js:1
_write @ common-1.js:1
S @ common-8.js:1
(anonymous) @ common-8.js:1
(anonymous) @ common-8.js:1
l @ common-5.js:13
(anonymous) @ common-5.js:13
H @ common-5.js:13
U @ common-5.js:13
F.push @ common-5.js:13
_onMessage @ common-5.js:13
(anonymous) @ common-5.js:13Understand this errorAI

sentry-install.js:1   **at o._write** (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-5.js:13:550465)
  at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-5.js:13:611855
  at C (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-5.js:13:611923)
  at I.write (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-5.js:13:615291)
  at c.h (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-8.js:1:27737)
  at c.emit (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-5.js:13:546666)
  at I (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-8.js:1:22542)
  at S (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-8.js:1:22372)
  at c.push (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-8.js:1:23159)
  at i._write (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-1.js:1:733016)
  at S (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-8.js:1:37745)
  at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-8.js:1:40845
  at i.write (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/common-8.js:1:40872)
  at i.<anonymous> (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background-5.js:1:472288)
"""

Detection stage

In production (default)

Version

12.10.1

Build type

None

Browser

Chrome

Operating system

Windows

Hardware wallet

Ledger

Additional context

No response

Severity

10/10 terrible

[Laurentiu-Andronache]

I can replicate the issue by just doing 20-30 transactions in a row with a lot of calldata. How to clear the transaction data from the Metamask local database without losing the wallets?

[benjisclowder]

@Laurentiu-Andronache Hi and thank you for reporting this. Can you please provide a bit more details regarding which type of transactions you were performing and what did the calldata look like that triggered this behavior? It would be a big help in the efforts of reproducing this. Currently, 20-30 regular transactions don't trigger this crash.

[Laurentiu-Andronache]

@Laurentiu-Andronache Hi and thank you for reporting this. Can you please provide a bit more details regarding which type of transactions you were performing and what did the calldata look like that triggered this behavior? It would be a big help in the efforts of reproducing this. Currently, 20-30 regular transactions don't trigger this crash.

Sure, it's 15-20 transactions like this one: https://basescan.org/tx/0x0a7bf0f34093701537c95cf973470ebd226063f0dd846b33a14d047a9451546e
It's easy to understand what they're about.

It would be cool if it can't load all the transactions, to just start with the ones currently loaded, or ask the user to reset them. Currently, it crashes. Is there a way to reset the transactions without reseting the wallet? I tried deleting the .ldb files but it just regenerates it and they're of very large size.

[Laurentiu-Andronache]

Here's how AppData\Local\Google\Chrome\User Data\Profile 2\IndexedDB\chrome-extension_nkbihfbeogaeaoehlefnkodbefgpgknn_0.indexeddb.leveldb looks like, notice the large files:

[Laurentiu-Andronache]

Is there some way to still access the wallets? Or I need to wait for a Metamask fix?

[Laurentiu-Andronache]

Is there some way to still access the wallets? I can share screen with a Metamask dev and maybe we achieve something?

[Laurentiu-Andronache]

@gauthierpetetin @benjisclowder @dbrans to replicate this:

Disperse an airdrop with a test token on Base!
You can use https://disperse.app or https://drop.gaslite.org
Disperse to 1500 addresses at a time, up to 2000. After ~12 such transactions Metamask shouldn't finish loading anymore when you click on the icon. To prevent the issue, you'd have to click on this button every 10 transactions.

[gauthierpetetin]

Hi @Laurentiu-Andronache , thanks a lot for the additional information.
Could you please reach out to our support (https://support.metamask.io/), such that we can plan a screen sharing session with you and @danjm ?

[Laurentiu-Andronache]

@gauthierpetetin they can't do it, but if you add me on @LaurWin on Discord, I can share screen there.

[Laurentiu-Andronache]

They can't even open a GitHub link. I don't think Metamask support could be useful in any way.

[gauthierpetetin]

Sure I reached out to you on Discord (@gauthierpetetin)

[Laurentiu-Andronache]

Sure I reached out to you on Discord (@gauthierpetetin)

I accepted, you can call directly when you're around.

[Laurentiu-Andronache]

In 12.12.0 the wallet still crashes in the same way.

[davidmurdoch]

⚠️ Warning: Do not try this on a production build with real accounts and data you want to keep. It will very likely break your MetaMask installation. ⚠️

Reproduction steps are here: #30572

⚠️ Warning: Do not try this on a production build with real accounts and data you want to keep. It will very likely break your MetaMask installation. ⚠️

[davidmurdoch]

One approach to solve this is to reduce the amount of state transferred from the background to the UI:

In metamask-controller.js, we could add a controllers array to filter them out.

  /**
   * The metamask-state of the various controllers, made available to the UI
   *
   * @param {string[]} controllers - A list of controller names to include in the state.
   * If empty, all controllers are included.
   * @returns {object} status
   */
  getState(controllers = []) {
    const { vault } = this.keyringController.state;
    const isInitialized = Boolean(vault);
    const flatState = this.memStore.getFlatState(controllers);

    return {
      isInitialized,
      ...sanitizeUIState(flatState),
    };
  }

This approach would likely require updating much of the UI to handle partial state.

[davidmurdoch]

Some further information:

A single transaction can easily take up over 6MB of memory.

Simple state sent from the background to the UI is is about 25MB, after sending 3 large transactions it increased to over 73MB.

The data param of each transaction is stored at least 3 times per transaction.

getFlatState and sanitizeUIState are both horribly inefficient as well, which isn't related to this specific bug, but is related to performance issues.