DRAFT: SIP-26 Integration

[jiexi]

Steps to get manual testing environment setup:

• start a flask build of this branch yarn start:flask
• go to settings -> experimental
• toggle on Enable "Add a new Bitcoin account (Beta)"
• go to the accounts drop down at the top of the wallet, and click add an account
• you should see an option to add a bitcoin account now. Add a bitcoin account
• Go to https://metamask.github.io/test-dapp-multichain/latest/ (or any website)
• Execute the following code in the dev console

const extensionPort = chrome.runtime.connect(YOUR_EXTENSION_ID)
extensionPort.onMessage.addListener((msg) => {
    console.log(msg.data)
})


extensionPort.postMessage({
    type: 'caip-x',
    data: {
        "jsonrpc": "2.0",
        method: 'wallet_createSession',
        params: {
            requiredScopes: {},
            optionalScopes: {
                'bip122:000000000019d6689c085ae165831e93': {
                    methods: ['sendBitcoin'],
                    notifications: [],
                    accounts: []
                }
            },
        },
    }
})

extensionPort.postMessage({
    type: 'caip-x',
    data: {
        "jsonrpc": "2.0",
        method: 'wallet_invokeMethod',
  "params": {
    "scope": "bip122:000000000019d6689c085ae165831e93",
    "request": {
      "method": "sendBitcoin",
      "params": {
        recipients: {
          address: '0.1',
        },
        replaceable: true,
      }
    }
}}})

Related issues

Ticket: https://github.com/orgs/MetaMask/projects/146/views/6?pane=issue&itemId=94617458&issue=MetaMask%7CMetaMask-planning%7C3989
Upstream Extension: #27782
Core: MetaMask/core#5191

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[jiexi]

@metamaskbot update-policies

[metamaskbot]

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

[jiexi]

@metamaskbot update-policies

[metamaskbot]

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

[metamaskbot]

❌ API Spec Test Failed. View the report here.

[metamaskbot]

❌ Multichain API Spec Test Failed. View the report here.

[metamaskbot]

❌ API Spec Test Failed. View the report here.

[metamaskbot]

❌ Multichain API Spec Test Failed. View the report here.

[mcmire]

A couple of notes:

• The Bitcoin integration was disabled in chore(bitcoin): add bitcoin build feature + disable it temporarily #30477, so we have to use the Solana integration for testing. I think this could work:

  const extensionPort = chrome.runtime.connect(YOUR_EXTENSION_ID)
  
  extensionPort.onMessage.addListener((msg) => {
    console.log(msg.data)
  })
  
  extensionPort.postMessage({
    type: "caip-x",
    data: {
      jsonrpc: "2.0",
      method: "wallet_createSession",
      params: {
        requiredScopes: {},
        optionalScopes: {
          "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp": {
            methods: ["getAccount"],
            notifications: [],
            accounts: []
          }
        },
      },
    }
  })
  
  extensionPort.postMessage({
    type: "caip-x",
    data: {
      jsonrpc: "2.0",
      method: "wallet_invokeMethod",
      params: {
        scope: "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp",
        request: {
          method: "getAccount",
          params: [YOUR_SOLANA_ACCOUNT_ID]
        }
      }
    }
  })

• However, the above does not work, and in fact, the new changes introduced in this PR are breaking createSession, getSession, etc. I'm not sure why, I'll have to investigate.

[socket-security]

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected] ➜ 4.0.0	None	0	672 kB	metamaskbot

View full report↗︎

[metamaskbot]

Builds ready [552e273]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1671 ± 105 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1533	2339	1676	218	104
		domContentLoaded	1508	2290	1645	216	104
		load	1532	2347	1671	219	105
		domInteractive	25	95	39	18	9
		backgroundConnect	12	62	32	15	7
		firstReactRender	14	65	34	22	11
		getState	5	47	10	9	4
		initialActions	0	1	0	0	0
		loadScripts	1082	1805	1226	195	94
		setupStore	7	12	8	1	1
		uiStartup	1697	2545	1880	215	103

[metamaskbot]

Builds ready [c6b5bc7]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1912 ± 62 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	398	2150	1749	459	221
		domContentLoaded	1723	2086	1850	107	52
		load	1751	2190	1912	129	62
		domInteractive	25	75	36	14	7
		backgroundConnect	13	191	63	58	28
		firstReactRender	16	73	38	22	11
		getState	6	141	39	41	20
		initialActions	0	1	0	0	0
		loadScripts	1295	1591	1398	82	39
		setupStore	8	60	29	20	10
		uiStartup	2012	3184	2326	359	172