feat: Add Base to Smart Transaction supported chains #30678

httpJunkie · 2025-03-03T12:38:42Z

Description

What is the reason for the change?

Smart Transactions are currently supported on Ethereum Mainnet and BNB Smart Chain, but not on Base. As part of our effort to expand Smart Transactions functionality to more networks, Base needs to be added to the list of supported chains.

What is the improvement/solution?

This PR adds Base to the list of supported chains for Smart Transactions in the extension by:

Adding CHAIN_IDS.BASE to ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS_DEVELOPMENT
Adding CHAIN_IDS.BASE to ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS_PRODUCTION
Updating tests to include Base in the expected supported chains list

These changes allow the extension to recognize Base as a valid network for Smart Transactions, enabling users to benefit from Smart Transactions functionality when interacting with the Base network.

Related issues

Fixes: TXL-687

Manual testing steps

Since Base isn't supported yet and this PR simply adds Base to list of supported chains, we are not testing Base/STX functionality yet, but ensuring that existing functionality remains intact.

This PR updates the version of @metamask/smart-transactions-controller, confirm that it doesn't break anything. Manual testing included:

Verifying STX still works correctly on Ethereum Mainnet (see screenshot image)
Checking that network switching between supported networks maintains proper STX state
Ensuring STX settings UI correctly displays supported networks
Confirming swap transactions with STX enabled complete successfully
Ensuring that STX Description in Advanced Settings is correctly updated (see before/after images)

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

… Dev environments.

…r than listing each network we support in the description. - add `stxOptInSupportedNetworksDescription` and remove `stxOptInEthereumBnbDescription` from locales (`en` & `en_GB`) - update references to this description in `ui/helpers/constants/settings.js` - update references to this description in `ui/pages/settings/advanced-tab/advanced-tab.component.js`

github-actions · 2025-03-03T12:38:56Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

httpJunkie · 2025-03-03T14:09:31Z

I have read the CLA Document and I hereby sign the CLA

metamaskbot · 2025-03-04T07:35:56Z

Builds ready [5008e47]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1723 ± 79 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1517	2105	1727	165	79
		domContentLoaded	1506	2054	1694	156	75
		load	1519	2103	1723	164	79
		domInteractive	27	98	37	16	8
		backgroundConnect	12	91	33	20	10
		firstReactRender	15	75	36	24	12
		getState	5	56	17	17	8
		initialActions	0	1	0	0	0
		loadScripts	1093	1594	1271	137	66
		setupStore	8	58	20	18	9
		uiStartup	1735	2433	1961	189	91

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 12 Bytes (0.00%)
common: 22 Bytes (0.00%)

metamaskbot · 2025-03-04T11:53:47Z

Builds ready [4508701]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1772 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	282	2036	1636	451	217
		domContentLoaded	1506	1987	1740	127	61
		load	1517	2044	1772	136	65
		domInteractive	25	79	43	17	8
		backgroundConnect	9	86	33	21	10
		firstReactRender	15	75	35	22	11
		getState	5	56	20	17	8
		initialActions	0	1	0	0	0
		loadScripts	1115	1512	1298	120	58
		setupStore	7	56	15	13	6
		uiStartup	1684	2326	2010	150	72

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 12 Bytes (0.00%)
common: 22 Bytes (0.00%)

metamaskbot · 2025-03-04T14:56:22Z

Builds ready [b1321e7]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1701 ± 88 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1456	2295	1710	182	87
		domContentLoaded	1447	2286	1671	184	89
		load	1456	2295	1701	183	88
		domInteractive	25	89	41	17	8
		backgroundConnect	10	85	34	22	11
		firstReactRender	15	72	35	23	11
		getState	5	53	14	14	7
		initialActions	0	1	0	0	0
		loadScripts	1028	1842	1235	175	84
		setupStore	8	51	12	9	4
		uiStartup	1639	2574	1920	207	99

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 12 Bytes (0.00%)
common: 22 Bytes (0.00%)

socket-security · 2025-03-05T16:11:55Z

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected] ➜ 16.1.0	None	`0`	210 kB	metamaskbot

View full report↗︎

metamaskbot · 2025-03-05T17:22:29Z

Builds ready [e8eb886]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1719 ± 44 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1537	1952	1720	92	44
		domContentLoaded	1508	1899	1685	79	38
		load	1536	1955	1719	92	44
		domInteractive	23	138	43	24	12
		backgroundConnect	11	116	36	27	13
		firstReactRender	16	78	45	22	10
		getState	5	51	15	14	7
		initialActions	0	1	0	0	0
		loadScripts	1111	1483	1274	73	35
		setupStore	8	57	14	12	6
		uiStartup	1712	2261	1972	130	63

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 59 Bytes (0.00%)
ui: 12 Bytes (0.00%)
common: 22 Bytes (0.00%)

metamaskbot · 2025-03-06T19:55:51Z

Builds ready [3708d6a]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1823 ± 100 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1546	2181	1829	213	102
		domContentLoaded	1526	2156	1798	208	100
		load	1546	2177	1823	208	100
		domInteractive	16	128	44	24	11
		backgroundConnect	13	63	28	14	7
		firstReactRender	15	69	30	18	9
		getState	5	72	21	22	11
		initialActions	0	1	0	0	0
		loadScripts	1112	1707	1351	175	84
		setupStore	8	63	24	21	10
		uiStartup	1715	2488	2068	246	118

metamaskbot · 2025-03-07T15:42:49Z

Builds ready [f3305ff]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1882 ± 82 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1645	2293	1878	177	85
		domContentLoaded	1636	2272	1840	179	86
		load	1642	2289	1882	171	82
		domInteractive	25	80	37	17	8
		backgroundConnect	10	176	52	41	20
		firstReactRender	16	63	32	17	8
		getState	4	95	21	22	11
		initialActions	0	1	0	0	0
		loadScripts	1230	1671	1382	134	64
		setupStore	7	63	16	15	7
		uiStartup	1813	2942	2185	256	123

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 59 Bytes (0.00%)
ui: 12 Bytes (0.00%)
common: 5 Bytes (0.00%)

httpJunkie added 2 commits March 3, 2025 07:22

feat: add Base to allowed STX Chain IDs and relevant tests for Prod &…

b485d75

… Dev environments.

httpJunkie added the team-transactions Transactions team label Mar 3, 2025

httpJunkie self-assigned this Mar 3, 2025

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 3, 2025

feat: update test for advanced-tab.component.test.js

d27ce64

httpJunkie changed the title ~~Feat: Add Base to Smart Transaction supported chains~~ feat: Add Base to Smart Transaction supported chains Mar 3, 2025

httpJunkie added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Mar 3, 2025

httpJunkie added 2 commits March 3, 2025 09:31

Merge branch 'main' into feat/add-base-to-stx-supported-chains

8135e87

Merge branch 'main' into feat/add-base-to-stx-supported-chains

5008e47

Merge branch 'main' into feat/add-base-to-stx-supported-chains

4508701

Merge branch 'main' into feat/add-base-to-stx-supported-chains

b1321e7

httpJunkie added 4 commits March 4, 2025 20:57

Merge branch 'main' into feat/add-base-to-stx-supported-chains

4ea2aef

Merge branch 'main' into feat/add-base-to-stx-supported-chains

39e6866

Merge branch 'main' into feat/add-base-to-stx-supported-chains

bd031df

feat: bump version of @metamask/smart-transactions-controller

f782722

httpJunkie added 2 commits March 5, 2025 11:18

Merge branch 'main' into feat/add-base-to-stx-supported-chains

52352a6

Merge branch 'main' into feat/add-base-to-stx-supported-chains

e8eb886

httpJunkie requested a review from dan437 March 5, 2025 19:23

httpJunkie added 2 commits March 6, 2025 14:19

fix: remove Base from STX production until ready (w/ todo comment)

98cc2a9

Merge branch 'main' into feat/add-base-to-stx-supported-chains

3708d6a

httpJunkie removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 6, 2025

dan437 approved these changes Mar 7, 2025

View reviewed changes

httpJunkie added 2 commits March 7, 2025 09:38

Merge branch 'main' into feat/add-base-to-stx-supported-chains

386e182

Merge branch 'main' into feat/add-base-to-stx-supported-chains

f3305ff

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add Base to Smart Transaction supported chains #30678

feat: Add Base to Smart Transaction supported chains #30678

httpJunkie commented Mar 3, 2025 •

edited

Loading

github-actions bot commented Mar 3, 2025

httpJunkie commented Mar 3, 2025

metamaskbot commented Mar 4, 2025

metamaskbot commented Mar 4, 2025

metamaskbot commented Mar 4, 2025

socket-security bot commented Mar 5, 2025 •

edited

Loading

metamaskbot commented Mar 5, 2025

metamaskbot commented Mar 6, 2025

metamaskbot commented Mar 7, 2025

feat: Add Base to Smart Transaction supported chains #30678

Are you sure you want to change the base?

feat: Add Base to Smart Transaction supported chains #30678

Conversation

httpJunkie commented Mar 3, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 3, 2025

httpJunkie commented Mar 3, 2025

metamaskbot commented Mar 4, 2025

metamaskbot commented Mar 4, 2025

metamaskbot commented Mar 4, 2025

socket-security bot commented Mar 5, 2025 • edited Loading

metamaskbot commented Mar 5, 2025

metamaskbot commented Mar 6, 2025

metamaskbot commented Mar 7, 2025

httpJunkie commented Mar 3, 2025 •

edited

Loading

socket-security bot commented Mar 5, 2025 •

edited

Loading