Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove assets detection metrics #30730

Merged
merged 7 commits into from
Mar 6, 2025

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Mar 4, 2025

Description

stop firing these events for now until we really need to track this event again when we turn on NFT autodetection for all users.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb marked this pull request as ready for review March 4, 2025 15:47
@salimtb salimtb requested a review from Prithpal-Sooriya March 4, 2025 17:01
@metamaskbot
Copy link
Collaborator

Builds ready [72d64b0]
Page Load Metrics (1837 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint40621381768337162
domContentLoaded15682066179712761
load16112126183712560
domInteractive28613584
backgroundConnect890382311
firstReactRender156729189
getState65318178
initialActions00000
loadScripts11441572134310852
setupStore85821188
uiStartup18242407210414067
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -499 Bytes (-0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [62464f0]
Page Load Metrics (1925 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16482199193415675
domContentLoaded16342119189816177
load16472129192515976
domInteractive24131522813
backgroundConnect1191352512
firstReactRender1776402311
getState76122199
initialActions01000
loadScripts12351630144113163
setupStore1062262010
uiStartup19122500220917886
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -499 Bytes (-0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@salimtb salimtb added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit bac5a79 Mar 6, 2025
74 checks passed
@salimtb salimtb deleted the fix/remove-assets-autodetection-metrics branch March 6, 2025 11:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants