Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: First time interaction warning should be shown in dApp request as warning #30800

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Mar 6, 2025

Description

First time interaction with dApp request should be shown as an alert in confirmation.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4367

Manual testing steps

Screenshots/Recordings

Before

Screenshot 2025-03-06 at 06 10 33

After

Screenshot 2025-03-06 at 06 09 47

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner March 6, 2025 05:11
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Mar 6, 2025
@@ -7,7 +7,7 @@ export enum RowAlertKey {
Network = 'network',
Resimulation = 'resimulation',
Speed = 'speed',
To = 'to',
InteractingWith = 'interactingWith',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same alert for the warning that we show in To field, as expected we named To in RowAlertKey enum. This PR fixes that warning will be shown in InteractingWith field.
Hence I am renaming this warning as InteractingWith because it describes warning better than To.

@metamaskbot
Copy link
Collaborator

Builds ready [f4b966b]
Page Load Metrics (1599 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13921908160214871
domContentLoaded13781882156713364
load13881909159914771
domInteractive23132402914
backgroundConnect11108352813
firstReactRender1465302010
getState46012147
initialActions00000
loadScripts10281426117311555
setupStore75515167
uiStartup15552134181016378

jpuri
jpuri previously approved these changes Mar 6, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [4ea59f6]
Page Load Metrics (1571 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1465169115726632
domContentLoaded1454167915447033
load1469169315716732
domInteractive248237189
backgroundConnect105529168
firstReactRender1467272110
getState47115188
initialActions01000
loadScripts1043130011445928
setupStore75413126
uiStartup1688191817826531

@metamaskbot
Copy link
Collaborator

Builds ready [0de9d43]
Page Load Metrics (1746 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15042219174216680
domContentLoaded14892189171516378
load15042268174617383
domInteractive26107422211
backgroundConnect986332210
firstReactRender1570362311
getState56213157
initialActions01000
loadScripts10971768128415374
setupStore95719178
uiStartup17302565198418488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants