Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Provide required useEffect dependencies in TokenCell and AggregatedPercentageOverview #30876

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Mar 7, 2025

Description

Fixes console warnings for these two components by providing required dependencies

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Ensure both components display accurate information
  2. Don't see warnings in console.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from gambinish March 7, 2025 22:48
Copy link
Contributor

github-actions bot commented Mar 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [6736c4b]
Page Load Metrics (1968 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17672206196111957
domContentLoaded17042094190610249
load17702333196813364
domInteractive17140493416
backgroundConnect12328646732
firstReactRender1681362311
getState6116322914
initialActions0452105
loadScripts1284161114529043
setupStore85518157
uiStartup202436942288349167
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -12 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants