Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: more translations to token alerts #30877

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

GustavoRSSilva
Copy link
Contributor

@GustavoRSSilva GustavoRSSilva commented Mar 7, 2025

Description

Just adding another alert to the alerts transactions

Open in GitHub Codespaces

Related issues

Fixes: None

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@GustavoRSSilva GustavoRSSilva changed the title chore: more translations chore: more translations to token alerts Mar 7, 2025
@metamaskbot metamaskbot added the team-swaps-and-bridge Team swaps and bridge label Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds a new token alert translation to support concentrated supply distribution cases.

  • Added a new case in the translation utility for 'CONCENTRATED_SUPPLY_DISTRIBUTION' to set custom title and description translation keys.

Reviewed Changes

File Description
shared/modules/bridge-utils/security-alerts-api.util.ts Adds a case to handle concentrated supply distribution alerts by setting the appropriate translation keys

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

shared/modules/bridge-utils/security-alerts-api.util.ts:114

  • Please ensure that translation keys 'concentratedSupplyDistributionTitle' and 'concentratedSupplyDistributionDescription' are available in the localization files to avoid missing or incorrect text in the UI.
case 'CONCENTRATED_SUPPLY_DISTRIBUTION':
@metamaskbot
Copy link
Collaborator

Builds ready [7da74d5]
Page Load Metrics (1915 ± 114 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint65125281851360173
domContentLoaded163624251874221106
load164825481915236114
domInteractive25124422713
backgroundConnect13120472914
firstReactRender147233199
getState55420168
initialActions00000
loadScripts12261877141717383
setupStore76517168
uiStartup183531232206355171
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 131 Bytes (0.00%)
  • common: 252 Bytes (0.00%)

micaelae
micaelae previously approved these changes Mar 8, 2025
ghgoodreau
ghgoodreau previously approved these changes Mar 8, 2025
@GustavoRSSilva GustavoRSSilva dismissed stale reviews from ghgoodreau and micaelae via b439ea1 March 8, 2025 22:36
@metamaskbot
Copy link
Collaborator

Builds ready [b439ea1]
Page Load Metrics (1902 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint47124221841353170
domContentLoaded15582395185516077
load15692423190216780
domInteractive268836136
backgroundConnect12136483617
firstReactRender1676342110
getState595212211
initialActions01000
loadScripts11441887141414268
setupStore870242110
uiStartup179528142212238114
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 131 Bytes (0.00%)
  • common: 252 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-swaps-and-bridge Team swaps and bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants