Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set automatic slippage for swap transactions #30878

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Mar 7, 2025

Description

This sets slippage to undefined when swapping in Solana. The bridge-api fetches quotes with an optimal slippage in this case

Open in GitHub Codespaces

Related issues

Fixes: #30796

Manual testing steps

  1. Open background logs
  2. Fetch solana swap quotes
  3. Check that there's no slippage passed to getQuote network call

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@micaelae micaelae force-pushed the fix-swap-auto-slippage branch from af25162 to f1b840c Compare March 7, 2025 23:34
@micaelae micaelae added the team-swaps-and-bridge Team swaps and bridge label Mar 7, 2025
@micaelae micaelae marked this pull request as ready for review March 7, 2025 23:52
@micaelae micaelae requested a review from a team as a code owner March 7, 2025 23:52
@metamaskbot
Copy link
Collaborator

Builds ready [f1b840c]
Page Load Metrics (2001 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51822241843457219
domContentLoaded17342191195314570
load17482243200115775
domInteractive29121492914
backgroundConnect14123522713
firstReactRender157535199
getState67024199
initialActions01000
loadScripts13051686149912259
setupStore86119168
uiStartup19962697229719493
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 30 Bytes (0.00%)
  • common: 108 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-swaps-and-bridge Team swaps and bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Occasionally seeing transaction reverted to due slippage exceed during swap
4 participants