-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Closed
Labels
INVALID-ISSUE-TEMPLATEIssue's body doesn't match any issue template.Issue's body doesn't match any issue template.good first issueGood for newcomersGood for newcomersrelease-13.7.0Issue or pull request that will be included in release 13.7.0Issue or pull request that will be included in release 13.7.0team-design-systemAll issues relating to design system in ExtensionAll issues relating to design system in Extension
Description
Description
Currently, the extension is using an outdated ErrorMessage component, which needs to be replaced with the new BannerAlert component.
This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements.
Technical Details
- Replace instances of
ErrorMessagecomponent (ui/components/ui/error-message/error-message.component.js) withBannerAlertcomponent (ui/components/component-library/banner-alert/banner-alert.js) - Component APIs are slightly different so ensure all props have been migrated appropriately
Acceptance Criteria
- Instances of
ErrorMessagecomponent are completely replaced with the newBannerAlertcomponent - The component APIs are updated to reflect the changes in the new `ErrorMessage`` component and there is no functional changes or visual regression
- Each Pull Request (PR) should include no more than 3 files
- The code changes should pass Jest tests, linting, and Storybook without any errors.
- The PR must include before and after screenshots of the UI to ensure there are no visual regressions.
If the acceptance criteria is not met, PRs may be closed.
Difficulty: Intermediate
Good first issue for: External contributors who are familiar with running the extension locally, have knowledge of React, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in the extension
Metadata
Metadata
Assignees
Labels
INVALID-ISSUE-TEMPLATEIssue's body doesn't match any issue template.Issue's body doesn't match any issue template.good first issueGood for newcomersGood for newcomersrelease-13.7.0Issue or pull request that will be included in release 13.7.0Issue or pull request that will be included in release 13.7.0team-design-systemAll issues relating to design system in ExtensionAll issues relating to design system in Extension