Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: calculate solana quote fees #30574

Merged
merged 11 commits into from
Feb 27, 2025
Merged

feat: calculate solana quote fees #30574

merged 11 commits into from
Feb 27, 2025

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Feb 26, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@micaelae micaelae force-pushed the mms1868-solana-tx-fees branch from 987250a to c73d301 Compare February 26, 2025 23:32
@micaelae micaelae changed the base branch from main to mms1869-submit-sol-tx February 26, 2025 23:32
@micaelae micaelae force-pushed the mms1868-solana-tx-fees branch from c73d301 to dc1ee72 Compare February 26, 2025 23:42
@micaelae micaelae marked this pull request as ready for review February 27, 2025 17:59
@micaelae micaelae requested a review from a team as a code owner February 27, 2025 17:59
@micaelae micaelae changed the base branch from mms1869-submit-sol-tx to main February 27, 2025 18:14
@micaelae micaelae requested a review from a team as a code owner February 27, 2025 18:14
@micaelae micaelae force-pushed the mms1868-solana-tx-fees branch from 551346d to 67af63f Compare February 27, 2025 19:58
@metamaskbot
Copy link
Collaborator

Builds ready [51fa876]
Page Load Metrics (1894 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30022271657579278
domContentLoaded15352205186416780
load15522228189416981
domInteractive25131392311
backgroundConnect1184292110
firstReactRender1574312010
getState66324199
initialActions01000
loadScripts11061707139413967
setupStore85619178
uiStartup18352488215318388
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 952 Bytes (0.02%)
  • ui: 1.3 KiB (0.02%)
  • common: 511 Bytes (0.01%)

@micaelae micaelae added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit 8a1d58c Feb 27, 2025
79 checks passed
@micaelae micaelae deleted the mms1868-solana-tx-fees branch February 27, 2025 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-bridge team-swaps-and-bridge Team swaps and bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants